[PATCH] HID: wacom: Report full pressure range for Intuos, Cintiq 13HD Touch

[PATCH] HID: wacom: Report full pressure range for Intuos, Cintiq 13HD Touch

[Jason Gerecke]

The new Intuos tablets added in eda01da and the Cintiq 13HD Touch added
in b4bf212 are capable of reporting 2048 levels of pressure. Although the
kernel reports the correct range to userspace, an oversight has resulted
in the driver ingoring the 11th pressure bit and only sending pressures
of 0 through 1023.

We could fix this issue by expanding the type check to include these
devices, but it makes much more sense to just have the driver look at
the device's maximum pressure when determining if it should read the
11th bit.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
---
 drivers/hid/wacom_wac.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index e0b9320..ddee08d 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -765,7 +765,7 @@ static void wacom_intuos_general(struct wacom_wac *wacom)
 	/* general pen packet */
 	if ((data[1] & 0xb8) == 0xa0) {
 		t = (data[6] << 2) | ((data[7] >> 6) & 3);
-		if (features->type >= INTUOS4S && features->type <= CINTIQ_COMPANION_2) {
+		if (features->pressure_max == 2047) {
 			t = (t << 1) | (data[1] & 1);
 		}
 		input_report_abs(input, ABS_PRESSURE, t);
-- 
2.6.1

Re: [PATCH] HID: wacom: Report full pressure range for Intuos, Cintiq 13HD Touch

[Jiri Kosina]

On Thu, 15 Oct 2015, Jason Gerecke wrote:

> The new Intuos tablets added in eda01da and the Cintiq 13HD Touch added
> in b4bf212 are capable of reporting 2048 levels of pressure. Although the
> kernel reports the correct range to userspace, an oversight has resulted
> in the driver ingoring the 11th pressure bit and only sending pressures
> of 0 through 1023.
> 
> We could fix this issue by expanding the type check to include these
> devices, but it makes much more sense to just have the driver look at
> the device's maximum pressure when determining if it should read the
> 11th bit.
> 
> Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>

Applied to for-4.4/wacom.

-- 
Jiri Kosina
SUSE Labs