linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Karsten Merker <merker@debian.org>
To: Bastien Nocera <hadess@hadess.net>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Irina Tirdea <irina.tirdea@intel.com>,
	Aleksei Mamlin <mamlinav@gmail.com>,
	linux-input@vger.kernel.org,
	Ian Campbell <ijc+devicetree@hellion.org.uk>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chen-Yu Tsai <wens@csie.org>, Karsten Merker <merker@debian.org>
Subject: [PATCH RFC V3 0/3] Input: goodix - add axis swapping and axis inversion support
Date: Sun, 18 Oct 2015 17:52:56 +0200	[thread overview]
Message-ID: <1445183579-29176-1-git-send-email-merker@debian.org> (raw)

Hello,

this is v3 of my "Input: goodix - add axis swapping and axis inversion
support" patchset.

The goodix touchscreen driver has gained device-tree support in kernel
4.1, but doesn't currently support the touchscreen-swapped-x-y,
touchscreen-inverted-x and touchscreen-inverted-y properties.
On systems which combine a portrait-mode display with a landscape-mode
touchscreen, such as e.g. the MSI Primo 81 tablet, support for these
features is necessary to have the touchscreen and the display use the
same coordinate system.

With support for axis inversion, the "rotated_screen" flag in the
driver can also be removed, as "rotated_screen" is just a special case
of x/y axis inversion.

This patchset sits on top of the "[PATCH v9 0/9] Goodix touchscreen
enhancements" series by Irina Tirdea:
https://www.spinics.net/lists/linux-input/msg41501.html

The axis swapping has successfully been tested on an (arm-based)
MSI Primo 81 tablet; the x/y inversion resp. the rotated_screen
functionality has successfully been tested on a WinBook TW100.

@Bastien: You had acked patch No. 1 in v2 of the patchset. I have
          not transferred that ack to v3 of the same patch
          because I have have introduced some changes into that
          patch (based on Irina's review comments, cf. the
          changelog below) after your ack.  I would apprechiate
          very much if you could take a look and tell me whether
          your ack extends to v3 as well.

Regards,
Karsten

Changelog:

v1: * Initial version (based von v6 of Irina Tirdea's "Goodix
      touchscreen enhancements" series).
      Reviewed-by: Bastien Nocera <hadess@hadess.net>

v2: * Rebase against v8 of Irina Tirdea's "Goodix touchscreen
      enhancements" series.
    * Fix a typo in the commit message.
    * Add an update for the goodix dt bindings documentation
      (patch No. 3).
    * Reviews/Tests:
      Patch 1+2: Tested-by: Bastien Nocera <hadess@hadess.net>
                 Acked-by: Bastien Nocera <hadess@hadess.net>
      Patch 2+3: Reviewed-by: Irina Tirdea <irina.tirdea@intel.com>

v3: * Rebase against v9 of Irina Tirdea's "Goodix touchscreen
      enhancements" series.
    * Address the review comments for patch No. 1 by Irina Tirdea
      (https://www.spinics.net/lists/linux-input/msg41536.html):
      - Move reading the dt properties from goodix_ts_probe to
        goodix_configure_dev to make them work properly in all
        configurations (with and without gpio declarations).
      - Use the new unified device properties API (device_property_*)
        instead of the classic DT API (of_property_*). This
        provides support for ACPI 5.1 DSD properties as well as 
        for device-tree properties.

Karsten Merker (3):
  Input: goodix - add axis swapping and axis inversion support
  Input: goodix - use "inverted_[xy]" flags instead of "rotated_screen"
  Input: goodix - update dt bindings documentation (axis
    swapping/inversion)

 .../bindings/input/touchscreen/goodix.txt          |  6 +++++
 drivers/input/touchscreen/goodix.c                 | 31 ++++++++++++++++++----
 2 files changed, 32 insertions(+), 5 deletions(-)

-- 
2.1.4

             reply	other threads:[~2015-10-18 15:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-18 15:52 Karsten Merker [this message]
2015-10-18 15:52 ` [PATCH RFC V3 1/3] Input: goodix - add axis swapping and axis inversion support Karsten Merker
2015-10-19 14:34   ` Tirdea, Irina
     [not found] ` <1445183579-29176-1-git-send-email-merker-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
2015-10-18 15:52   ` [PATCH RFC V3 2/3] Input: goodix - use "inverted_[xy]" flags instead of "rotated_screen" Karsten Merker
2015-10-18 15:52   ` [PATCH RFC V3 3/3] Input: goodix - update dt bindings documentation (axis swapping/inversion) Karsten Merker
2015-10-21 10:44 ` [PATCH RFC V3 0/3] Input: goodix - add axis swapping and axis inversion support Aleksei Mamlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445183579-29176-1-git-send-email-merker@debian.org \
    --to=merker@debian.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hadess@hadess.net \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=irina.tirdea@intel.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mamlinav@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).