From: WEN Pingbo <pingbo.wen@linaro.org>
To: arnd@arndb.de
Cc: y2038@lists.linaro.org, dmitry.torokhov@gmail.com,
WEN Pingbo <pingbo.wen@linaro.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: [PATCH V3 1/2] hil_mlc: convert timeval to time64_t
Date: Sat, 24 Oct 2015 12:00:18 +0800 [thread overview]
Message-ID: <1445659219-23135-1-git-send-email-pingbo.wen@linaro.org> (raw)
In-Reply-To: <5201254.PnVcGHTDmH@wuerfel>
Since mlc->lcv_t is only interested in seconds,
directly using time64_t here
Signed-off-by: WEN Pingbo <pingbo.wen@linaro.org>
---
Version 2:
Convert timeval to ktime_t
Version 3:
Convert it to time64_t, since it's a better choice
drivers/input/serio/hil_mlc.c | 8 +++-----
include/linux/hil_mlc.h | 2 +-
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/input/serio/hil_mlc.c b/drivers/input/serio/hil_mlc.c
index 65605e4..fb297aa 100644
--- a/drivers/input/serio/hil_mlc.c
+++ b/drivers/input/serio/hil_mlc.c
@@ -274,14 +274,12 @@ static int hilse_match(hil_mlc *mlc, int unused)
/* An LCV used to prevent runaway loops, forces 5 second sleep when reset. */
static int hilse_init_lcv(hil_mlc *mlc, int unused)
{
- struct timeval tv;
+ time64_t now = ktime_get_seconds();
- do_gettimeofday(&tv);
-
- if (mlc->lcv && (tv.tv_sec - mlc->lcv_tv.tv_sec) < 5)
+ if (mlc->lcv && (now - mlc->lcv_t) < 5)
return -1;
- mlc->lcv_tv = tv;
+ mlc->lcv_t = now;
mlc->lcv = 0;
return 0;
diff --git a/include/linux/hil_mlc.h b/include/linux/hil_mlc.h
index 394a840..29bb5e3 100644
--- a/include/linux/hil_mlc.h
+++ b/include/linux/hil_mlc.h
@@ -149,7 +149,7 @@ struct hil_mlc {
int ddi; /* Last operational device id */
int lcv; /* LCV to throttle loops */
- struct timeval lcv_tv; /* Time loop was started */
+ time64_t lcv_t; /* Time loop was started */
int di_map[7]; /* Maps below items to live devs */
struct hil_mlc_devinfo di[HIL_MLC_DEVMEM];
--
1.9.1
_______________________________________________
Y2038 mailing list
Y2038@lists.linaro.org
https://lists.linaro.org/mailman/listinfo/y2038
next prev parent reply other threads:[~2015-10-24 4:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 9:45 [PATCH] hil_mlc: convert timeval to timespec64 WEN Pingbo
2015-10-19 8:58 ` [Y2038] " Arnd Bergmann
2015-10-23 9:12 ` Pingbo Wen
2015-10-23 9:45 ` Arnd Bergmann
2015-10-23 12:34 ` Pingbo Wen
2015-10-24 4:00 ` WEN Pingbo [this message]
2015-10-24 4:00 ` [PATCH V3 2/2] hil_mlc: convert timeval to jiffies WEN Pingbo
2015-10-23 9:24 ` [PATCH V2] hil_mlc: convert timeval to ktime_t WEN Pingbo
2015-10-23 9:55 ` [Y2038] " Arnd Bergmann
2015-10-23 12:32 ` Pingbo Wen
2015-10-23 13:51 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445659219-23135-1-git-send-email-pingbo.wen@linaro.org \
--to=pingbo.wen@linaro.org \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).