* [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover
@ 2015-10-27 23:33 savoca
2015-10-30 13:53 ` Jiri Kosina
0 siblings, 1 reply; 9+ messages in thread
From: savoca @ 2015-10-27 23:33 UTC (permalink / raw)
To: Jiri Kosina
Cc: linux-input-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-usb-u79uwXL29TY76Z2rM5mHXA
Adding support for device 0x07e8 (SP4 Type Cover)
Signed-off-by: savoca <alex.deddo-Ienh7sBagb8AvxtiuMwx3w@public.gmane.org>
---
drivers/hid/hid-core.c | 2 ++
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-microsoft.c | 2 ++
drivers/hid/usbhid/hid-quirks.c | 1 +
4 files changed, 6 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 70a11ac..d54dde5 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -727,6 +727,7 @@ static void hid_scan_collection(struct hid_parser *parser, unsigned type)
(hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 ||
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP ||
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 ||
+ hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4 ||
hid->product == USB_DEVICE_ID_MS_POWER_COVER) &&
hid->group == HID_GROUP_MULTITOUCH)
hid->group = HID_GROUP_GENERIC;
@@ -1930,6 +1931,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY, USB_DEVICE_ID_GENIUS_KB29E) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index f769208..cebeb0a 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -681,6 +681,7 @@
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 0x07dc
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd
#define USB_DEVICE_ID_MS_TYPE_COVER_3 0x07de
+#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4 0x07e8
#define USB_DEVICE_ID_MS_POWER_COVER 0x07da
#define USB_VENDOR_ID_MOJO 0x8282
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
index 9aa3515..b663abf 100644
--- a/drivers/hid/hid-microsoft.c
+++ b/drivers/hid/hid-microsoft.c
@@ -282,6 +282,8 @@ static const struct hid_device_id ms_devices[] = {
.driver_data = MS_HIDINPUT },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3),
.driver_data = MS_HIDINPUT },
+ { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4),
+ .driver_data = MS_HIDINPUT },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER),
.driver_data = MS_HIDINPUT },
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 1dff8f0..954aedd 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -93,6 +93,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, HID_QUIRK_NO_INIT_REPORTS },
+ { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, HID_QUIRK_NO_INIT_REPORTS },
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover
2015-10-27 23:33 savoca
@ 2015-10-30 13:53 ` Jiri Kosina
2015-10-30 17:49 ` Andy Shevchenko
0 siblings, 1 reply; 9+ messages in thread
From: Jiri Kosina @ 2015-10-30 13:53 UTC (permalink / raw)
To: savoca; +Cc: linux-input, linux-kernel, linux-usb
On Tue, 27 Oct 2015, savoca wrote:
> Adding support for device 0x07e8 (SP4 Type Cover)
>
> Signed-off-by: savoca <alex.deddo@daqri.com>
Thanks for the patch.
The authorship and signoffs should same real names though. Could you
please resend with that fixed?
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover
2015-10-30 13:53 ` Jiri Kosina
@ 2015-10-30 17:49 ` Andy Shevchenko
2015-10-30 18:39 ` Andy Shevchenko
2015-10-30 22:49 ` Jiri Kosina
0 siblings, 2 replies; 9+ messages in thread
From: Andy Shevchenko @ 2015-10-30 17:49 UTC (permalink / raw)
To: Jiri Kosina; +Cc: savoca, linux-input, linux-kernel@vger.kernel.org, USB
On Fri, Oct 30, 2015 at 3:53 PM, Jiri Kosina <jikos@kernel.org> wrote:
> On Tue, 27 Oct 2015, savoca wrote:
>
>> Adding support for device 0x07e8 (SP4 Type Cover)
>>
>> Signed-off-by: savoca <alex.deddo@daqri.com>
>
> Thanks for the patch.
>
> The authorship and signoffs should same real names though. Could you
> please resend with that fixed?
>
Have you guys noticed the patch [1] to support Surface Book along with
Surface Pro 3?
[1] https://github.com/neoreeps/surface-pro-3/blob/master/wily_surface.patch
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover
@ 2015-10-30 18:22 savoca
0 siblings, 0 replies; 9+ messages in thread
From: savoca @ 2015-10-30 18:22 UTC (permalink / raw)
To: Jiri Kosina; +Cc: linux-input, linux-kernel, linux-usb, Alex Deddo
From: Alex Deddo <alex.deddo@daqri.com>
Adding support for device 0x07e8 (SP4 Type Cover)
Signed-off-by: Alex Deddo <alex.deddo@daqri.com>
---
drivers/hid/hid-core.c | 2 ++
drivers/hid/hid-ids.h | 1 +
drivers/hid/hid-microsoft.c | 2 ++
drivers/hid/usbhid/hid-quirks.c | 1 +
4 files changed, 6 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 70a11ac..d54dde5 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -727,6 +727,7 @@ static void hid_scan_collection(struct hid_parser *parser, unsigned type)
(hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 ||
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP ||
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 ||
+ hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4 ||
hid->product == USB_DEVICE_ID_MS_POWER_COVER) &&
hid->group == HID_GROUP_MULTITOUCH)
hid->group = HID_GROUP_GENERIC;
@@ -1930,6 +1931,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MONTEREY, USB_DEVICE_ID_GENIUS_KB29E) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index f769208..cebeb0a 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -681,6 +681,7 @@
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 0x07dc
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd
#define USB_DEVICE_ID_MS_TYPE_COVER_3 0x07de
+#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4 0x07e8
#define USB_DEVICE_ID_MS_POWER_COVER 0x07da
#define USB_VENDOR_ID_MOJO 0x8282
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
index 9aa3515..b663abf 100644
--- a/drivers/hid/hid-microsoft.c
+++ b/drivers/hid/hid-microsoft.c
@@ -282,6 +282,8 @@ static const struct hid_device_id ms_devices[] = {
.driver_data = MS_HIDINPUT },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3),
.driver_data = MS_HIDINPUT },
+ { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4),
+ .driver_data = MS_HIDINPUT },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER),
.driver_data = MS_HIDINPUT },
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 1dff8f0..954aedd 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -93,6 +93,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3, HID_QUIRK_NO_INIT_REPORTS },
+ { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_POWER_COVER, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MSI, USB_DEVICE_ID_MSI_GT683R_LED_PANEL, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_NEXIO, USB_DEVICE_ID_NEXIO_MULTITOUCH_PTI0750, HID_QUIRK_NO_INIT_REPORTS },
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover
2015-10-30 17:49 ` Andy Shevchenko
@ 2015-10-30 18:39 ` Andy Shevchenko
[not found] ` <CAJ+BiKoZruvQQFQG0sJgzOM-uFbWwNYrW8R1+MDjiv+Rxe1C2Q@mail.gmail.com>
2015-10-30 22:49 ` Jiri Kosina
1 sibling, 1 reply; 9+ messages in thread
From: Andy Shevchenko @ 2015-10-30 18:39 UTC (permalink / raw)
To: Jiri Kosina, Kenny Speer
Cc: savoca, linux-input, linux-kernel@vger.kernel.org, USB
Summon author, Kenny, of the mentioned patch.
On Fri, Oct 30, 2015 at 7:49 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, Oct 30, 2015 at 3:53 PM, Jiri Kosina <jikos@kernel.org> wrote:
>> On Tue, 27 Oct 2015, savoca wrote:
>>
>>> Adding support for device 0x07e8 (SP4 Type Cover)
>>>
>>> Signed-off-by: savoca <alex.deddo@daqri.com>
>>
>> Thanks for the patch.
>>
>> The authorship and signoffs should same real names though. Could you
>> please resend with that fixed?
>>
>
> Have you guys noticed the patch [1] to support Surface Book along with
> Surface Pro 3?
>
> [1] https://github.com/neoreeps/surface-pro-3/blob/master/wily_surface.patch
>
> --
> With Best Regards,
> Andy Shevchenko
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover
[not found] ` <CAJ+BiKoZruvQQFQG0sJgzOM-uFbWwNYrW8R1+MDjiv+Rxe1C2Q@mail.gmail.com>
@ 2015-10-30 19:41 ` Andy Shevchenko
0 siblings, 0 replies; 9+ messages in thread
From: Andy Shevchenko @ 2015-10-30 19:41 UTC (permalink / raw)
To: Kenny Speer
Cc: Jiri Kosina, savoca, linux-input, linux-kernel@vger.kernel.org,
USB
On Fri, Oct 30, 2015 at 9:21 PM, Kenny Speer <kenny.speer@gmail.com> wrote:
> Hi All, what information would you like?
Just found many patches are flying around to support MS Surface 3 /
Pro 3 / Pro 4 / Book.
https://groups.google.com/forum/?hl=en#!topic/linux-surface/VlE9JGvxEyg
I'm actually interested in Book support. So, I think someone has to
sort this out and prepare series based on what is found.
>
> BTW, here is the same patch for the 4.3rc7 kernel which already contains the
> surface button driver.
>
> https://github.com/neoreeps/surface-pro-3/blob/master/4.3_surface.patch
>
> ~kenny
>
> On Fri, Oct 30, 2015 at 11:39 AM, Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
>>
>> Summon author, Kenny, of the mentioned patch.
>>
>> On Fri, Oct 30, 2015 at 7:49 PM, Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>> > On Fri, Oct 30, 2015 at 3:53 PM, Jiri Kosina <jikos@kernel.org> wrote:
>> >> On Tue, 27 Oct 2015, savoca wrote:
>> >>
>> >>> Adding support for device 0x07e8 (SP4 Type Cover)
>> >>>
>> >>> Signed-off-by: savoca <alex.deddo@daqri.com>
>> >>
>> >> Thanks for the patch.
>> >>
>> >> The authorship and signoffs should same real names though. Could you
>> >> please resend with that fixed?
>> >>
>> >
>> > Have you guys noticed the patch [1] to support Surface Book along with
>> > Surface Pro 3?
>> >
>> > [1]
>> > https://github.com/neoreeps/surface-pro-3/blob/master/wily_surface.patch
>> >
>> > --
>> > With Best Regards,
>> > Andy Shevchenko
>>
>>
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover
2015-10-30 17:49 ` Andy Shevchenko
2015-10-30 18:39 ` Andy Shevchenko
@ 2015-10-30 22:49 ` Jiri Kosina
1 sibling, 0 replies; 9+ messages in thread
From: Jiri Kosina @ 2015-10-30 22:49 UTC (permalink / raw)
To: Andy Shevchenko
Cc: savoca, linux-input, linux-kernel@vger.kernel.org, USB,
Kenny Speer
On Fri, 30 Oct 2015, Andy Shevchenko wrote:
> >> Adding support for device 0x07e8 (SP4 Type Cover)
> >>
> >> Signed-off-by: savoca <alex.deddo@daqri.com>
> >
> > Thanks for the patch.
> >
> > The authorship and signoffs should same real names though. Could you
> > please resend with that fixed?
> >
>
> Have you guys noticed the patch [1] to support Surface Book along with
> Surface Pro 3?
Not really. A quick scan through my mailbox tells me that it has actually
never submitted to me for inclusion into the kernel.
> [1] https://github.com/neoreeps/surface-pro-3/blob/master/wily_surface.patch
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover
@ 2016-11-21 14:36 Jeff Farthing
2016-11-23 16:49 ` Jiri Kosina
0 siblings, 1 reply; 9+ messages in thread
From: Jeff Farthing @ 2016-11-21 14:36 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, linux-input
Add support for Surface Pro 4 Type Cover
Signed-off-by: Jeff Farthing <jeff@jfarthing.com>
---
drivers/hid/hid-core.c | 4 ++++
drivers/hid/hid-ids.h | 2 ++
drivers/hid/hid-microsoft.c | 4 ++++
drivers/hid/usbhid/hid-quirks.c | 2 ++
4 files changed, 12 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 2b89c70..1bbe329 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -727,6 +727,8 @@ static void hid_scan_collection(struct hid_parser
*parser, unsigned type)
(hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 ||
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 ||
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP ||
+ hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4 ||
+ hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_2 ||
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP ||
hid->product == USB_DEVICE_ID_MS_TYPE_COVER_3 ||
hid->product == USB_DEVICE_ID_MS_POWER_COVER) &&
@@ -1983,6 +1985,8 @@ static const struct hid_device_id
hid_have_special_driver[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_3) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_4) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_2) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_3) },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_DIGITAL_MEDIA_7K) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 575aa65..5525965 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -718,6 +718,8 @@
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3 0x07dc
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2 0x07e2
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP 0x07dd
+#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4 0x07e4
+#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_2 0x07e8
#define USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP 0x07e9
#define USB_DEVICE_ID_MS_TYPE_COVER_3 0x07de
#define USB_DEVICE_ID_MS_POWER_COVER 0x07da
diff --git a/drivers/hid/hid-microsoft.c b/drivers/hid/hid-microsoft.c
index c6cd392..5e592f0 100644
--- a/drivers/hid/hid-microsoft.c
+++ b/drivers/hid/hid-microsoft.c
@@ -280,6 +280,10 @@ static const struct hid_device_id ms_devices[] = {
.driver_data = MS_HIDINPUT },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP),
.driver_data = MS_HIDINPUT },
+ { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_4),
+ .driver_data = MS_HIDINPUT },
+ { HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_2),
+ .driver_data = MS_HIDINPUT },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP),
.driver_data = MS_HIDINPUT },
{ HID_USB_DEVICE(USB_VENDOR_ID_MICROSOFT,
USB_DEVICE_ID_MS_TYPE_COVER_3),
diff --git a/drivers/hid/usbhid/hid-quirks.c
b/drivers/hid/usbhid/hid-quirks.c
index e6cfd32..ac43bfc3 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -100,6 +100,8 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TOUCH_COVER_2,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_2,
HID_QUIRK_NO_INIT_REPORTS },
+ { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4,
HID_QUIRK_NO_INIT_REPORTS },
+ { USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_2,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_3_JP,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_PRO_4_JP,
HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_TYPE_COVER_3,
HID_QUIRK_NO_INIT_REPORTS },
--
2.10.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover
2016-11-21 14:36 Jeff Farthing
@ 2016-11-23 16:49 ` Jiri Kosina
0 siblings, 0 replies; 9+ messages in thread
From: Jiri Kosina @ 2016-11-23 16:49 UTC (permalink / raw)
To: Jeff Farthing; +Cc: Benjamin Tissoires, linux-input, Daniel Keller
On Mon, 21 Nov 2016, Jeff Farthing wrote:
> Add support for Surface Pro 4 Type Cover
>
> Signed-off-by: Jeff Farthing <jeff@jfarthing.com>
The identical patch has been sent by Daniel Keller (added to CC), but his
submission wasn't line-wrapped (yours was).
So I've applied Daniel's patch (to for-4.10/upstream branch), and
ammended your Signoff to it as well.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2016-11-23 16:49 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-30 18:22 [PATCH] HID: microsoft: Add support for Surface Pro 4 Type Cover savoca
-- strict thread matches above, loose matches on Subject: below --
2016-11-21 14:36 Jeff Farthing
2016-11-23 16:49 ` Jiri Kosina
2015-10-27 23:33 savoca
2015-10-30 13:53 ` Jiri Kosina
2015-10-30 17:49 ` Andy Shevchenko
2015-10-30 18:39 ` Andy Shevchenko
[not found] ` <CAJ+BiKoZruvQQFQG0sJgzOM-uFbWwNYrW8R1+MDjiv+Rxe1C2Q@mail.gmail.com>
2015-10-30 19:41 ` Andy Shevchenko
2015-10-30 22:49 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).