linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Irina Tirdea <irina.tirdea@intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Bastien Nocera <hadess@hadess.net>,
	Aleksei Mamlin <mamlinav@gmail.com>,
	Karsten Merker <merker@debian.org>,
	linux-input@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Octavian Purdila <octavian.purdila@intel.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Irina Tirdea <irina.tirdea@intel.com>
Subject: [PATCH v11 7/8] Input: goodix - add sysfs interface to dump config
Date: Thu, 19 Nov 2015 14:26:40 +0200	[thread overview]
Message-ID: <1447936001-21420-8-git-send-email-irina.tirdea@intel.com> (raw)
In-Reply-To: <1447936001-21420-1-git-send-email-irina.tirdea@intel.com>

Goodix devices have a configuration information register area that
specify various parameters for the device. The configuration information
has a specific format described in the Goodix datasheet. It includes X/Y
resolution, maximum supported touch points, interrupt flags, various
sesitivity factors and settings for advanced features (like gesture
recognition).

Export a sysfs interface that would allow reading the configuration
information. The default device configuration can be used as a starting
point for creating a valid configuration firmware used by the device at
init time to update its configuration.

This sysfs interface will be exported only if the gpio pins are properly
initialized from ACPI/DT.

Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Tested-by: Bastien Nocera <hadess@hadess.net>
Tested-by: Aleksei Mamlin <mamlinav@gmail.com>
---
 drivers/input/touchscreen/goodix.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c
index 28cbfa9..ea5042f 100644
--- a/drivers/input/touchscreen/goodix.c
+++ b/drivers/input/touchscreen/goodix.c
@@ -511,12 +511,35 @@ static ssize_t goodix_esd_timeout_store(struct device *dev,
 	return count;
 }
 
+static ssize_t goodix_dump_config_show(struct device *dev,
+				       struct device_attribute *attr, char *buf)
+{
+	struct goodix_ts_data *ts = dev_get_drvdata(dev);
+	u8 config[GOODIX_CONFIG_MAX_LENGTH];
+	int error, count = 0, i;
+
+	error = goodix_i2c_read(ts->client, GOODIX_REG_CONFIG_DATA,
+				config, ts->cfg_len);
+	if (error) {
+		dev_warn(&ts->client->dev,
+			 "Error reading config (%d)\n",  error);
+		return error;
+	}
+
+	for (i = 0; i < ts->cfg_len; i++)
+		count += scnprintf(buf + count, PAGE_SIZE - count, "%02x ",
+				   config[i]);
+	return count;
+}
+
 /* ESD timeout in ms. Default disabled (0). Recommended 2000 ms. */
 static DEVICE_ATTR(esd_timeout, S_IRUGO | S_IWUSR, goodix_esd_timeout_show,
 		   goodix_esd_timeout_store);
+static DEVICE_ATTR(dump_config, S_IRUGO, goodix_dump_config_show, NULL);
 
 static struct attribute *goodix_attrs[] = {
 	&dev_attr_esd_timeout.attr,
+	&dev_attr_dump_config.attr,
 	NULL
 };
 
-- 
1.9.1

  parent reply	other threads:[~2015-11-19 12:26 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 12:26 [PATCH v11 0/8] Goodix touchscreen enhancements Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 1/8] Input: goodix - use actual config length for each device type Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 2/8] Input: goodix - reset device at init Irina Tirdea
2015-11-19 15:25   ` Bastien Nocera
     [not found]     ` <1447946703.24088.73.camel-0MeiytkfxGOsTnJN9+BGXg@public.gmane.org>
2015-11-19 15:36       ` Tirdea, Irina
2015-11-20 15:41   ` Rob Herring
2015-11-23 16:31   ` Bastien Nocera
     [not found]   ` <1447936001-21420-3-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-12-08 12:04     ` Aleksei Mamlin
2015-11-19 12:26 ` [PATCH v11 3/8] Input: goodix - write configuration data to device Irina Tirdea
2015-11-19 18:20   ` Dmitry Torokhov
2015-11-20 13:13     ` Tirdea, Irina
2015-11-23 16:32   ` Bastien Nocera
2015-12-08 12:09   ` Aleksei Mamlin
2015-11-19 12:26 ` [PATCH v11 4/8] Input: goodix - add power management support Irina Tirdea
     [not found]   ` <1447936001-21420-5-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-19 18:24     ` Dmitry Torokhov
2015-11-19 22:18       ` Rafael J. Wysocki
2015-11-19 22:31         ` Dmitry Torokhov
2015-11-23 16:33   ` Bastien Nocera
2015-11-19 12:26 ` [PATCH v11 5/8] Input: goodix - use goodix_i2c_write_u8 instead of i2c_master_send Irina Tirdea
2015-11-19 12:26 ` [PATCH v11 6/8] Input: goodix - add support for ESD Irina Tirdea
     [not found]   ` <1447936001-21420-7-git-send-email-irina.tirdea-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-11-20 15:44     ` Rob Herring
2015-11-20 17:20       ` Dmitry Torokhov
2015-11-27 17:24       ` Tirdea, Irina
     [not found]         ` <1F3AC3675D538145B1661F571FE1805F2F1265D3-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-11-27 17:28           ` Dmitry Torokhov
2015-11-23 16:33   ` Bastien Nocera
2015-11-19 12:26 ` Irina Tirdea [this message]
2015-11-19 12:26 ` [PATCH v11 8/8] Input: goodix - add runtime power management support Irina Tirdea
2015-11-23 16:35   ` Bastien Nocera
2015-12-18  1:13 ` [PATCH v11 0/8] Goodix touchscreen enhancements Dmitry Torokhov
     [not found]   ` <20160105200343.GA3425@excalibur.cnev.de>
2016-01-05 22:07     ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447936001-21420-8-git-send-email-irina.tirdea@intel.com \
    --to=irina.tirdea@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mamlinav@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=merker@debian.org \
    --cc=octavian.purdila@intel.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).