* [PATCH] Input: smtpe-ts: better way of using of_property_read_u32()
@ 2015-11-24 7:06 Saurabh Sengar
2015-11-24 7:13 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Saurabh Sengar @ 2015-11-24 7:06 UTC (permalink / raw)
To: dmitry.torokhov, marex, viresh.kumar, linux-input, linux-kernel
Cc: Saurabh Sengar
better way of using of_property_read_u32(), helps remove one variable
and many 'if' conditions
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
drivers/input/touchscreen/stmpe-ts.c | 29 ++++++++++-------------------
1 file changed, 10 insertions(+), 19 deletions(-)
diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
index e414d43..51abe62 100644
--- a/drivers/input/touchscreen/stmpe-ts.c
+++ b/drivers/input/touchscreen/stmpe-ts.c
@@ -268,27 +268,18 @@ static void stmpe_ts_get_platform_info(struct platform_device *pdev,
struct stmpe_touch *ts)
{
struct device_node *np = pdev->dev.of_node;
- u32 val;
if (np) {
- if (!of_property_read_u32(np, "st,sample-time", &val))
- ts->sample_time = val;
- if (!of_property_read_u32(np, "st,mod-12b", &val))
- ts->mod_12b = val;
- if (!of_property_read_u32(np, "st,ref-sel", &val))
- ts->ref_sel = val;
- if (!of_property_read_u32(np, "st,adc-freq", &val))
- ts->adc_freq = val;
- if (!of_property_read_u32(np, "st,ave-ctrl", &val))
- ts->ave_ctrl = val;
- if (!of_property_read_u32(np, "st,touch-det-delay", &val))
- ts->touch_det_delay = val;
- if (!of_property_read_u32(np, "st,settling", &val))
- ts->settling = val;
- if (!of_property_read_u32(np, "st,fraction-z", &val))
- ts->fraction_z = val;
- if (!of_property_read_u32(np, "st,i-drive", &val))
- ts->i_drive = val;
+ of_property_read_u32(np, "st,sample-time", &ts->sample_time);
+ of_property_read_u32(np, "st,mod-12b", &ts->mod_12b);
+ of_property_read_u32(np, "st,ref-sel", &ts->ref_sel);
+ of_property_read_u32(np, "st,adc-freq", &ts->adc_freq);
+ of_property_read_u32(np, "st,ave-ctrl", &ts->ave_ctrl);
+ of_property_read_u32(np, "st,touch-det-delay",
+ &ts->touch_det_delay);
+ of_property_read_u32(np, "st,settling", &ts->settling = val);
+ of_property_read_u32(np, "st,fraction-z", &ts->fraction_z);
+ of_property_read_u32(np, "st,i-drive", &ts->i_drive);
}
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: smtpe-ts: better way of using of_property_read_u32()
2015-11-24 7:06 [PATCH] Input: smtpe-ts: better way of using of_property_read_u32() Saurabh Sengar
@ 2015-11-24 7:13 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2015-11-24 7:13 UTC (permalink / raw)
To: Saurabh Sengar; +Cc: dmitry.torokhov, marex, linux-input, linux-kernel
On 24-11-15, 12:36, Saurabh Sengar wrote:
> better way of using of_property_read_u32(), helps remove one variable
> and many 'if' conditions
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
> drivers/input/touchscreen/stmpe-ts.c | 29 ++++++++++-------------------
> 1 file changed, 10 insertions(+), 19 deletions(-)
>
> diff --git a/drivers/input/touchscreen/stmpe-ts.c b/drivers/input/touchscreen/stmpe-ts.c
> index e414d43..51abe62 100644
> --- a/drivers/input/touchscreen/stmpe-ts.c
> +++ b/drivers/input/touchscreen/stmpe-ts.c
> @@ -268,27 +268,18 @@ static void stmpe_ts_get_platform_info(struct platform_device *pdev,
> struct stmpe_touch *ts)
> {
> struct device_node *np = pdev->dev.of_node;
> - u32 val;
>
> if (np) {
> - if (!of_property_read_u32(np, "st,sample-time", &val))
> - ts->sample_time = val;
> - if (!of_property_read_u32(np, "st,mod-12b", &val))
> - ts->mod_12b = val;
> - if (!of_property_read_u32(np, "st,ref-sel", &val))
> - ts->ref_sel = val;
> - if (!of_property_read_u32(np, "st,adc-freq", &val))
> - ts->adc_freq = val;
> - if (!of_property_read_u32(np, "st,ave-ctrl", &val))
> - ts->ave_ctrl = val;
> - if (!of_property_read_u32(np, "st,touch-det-delay", &val))
> - ts->touch_det_delay = val;
> - if (!of_property_read_u32(np, "st,settling", &val))
> - ts->settling = val;
> - if (!of_property_read_u32(np, "st,fraction-z", &val))
> - ts->fraction_z = val;
> - if (!of_property_read_u32(np, "st,i-drive", &val))
> - ts->i_drive = val;
> + of_property_read_u32(np, "st,sample-time", &ts->sample_time);
> + of_property_read_u32(np, "st,mod-12b", &ts->mod_12b);
> + of_property_read_u32(np, "st,ref-sel", &ts->ref_sel);
> + of_property_read_u32(np, "st,adc-freq", &ts->adc_freq);
> + of_property_read_u32(np, "st,ave-ctrl", &ts->ave_ctrl);
> + of_property_read_u32(np, "st,touch-det-delay",
> + &ts->touch_det_delay);
> + of_property_read_u32(np, "st,settling", &ts->settling = val);
> + of_property_read_u32(np, "st,fraction-z", &ts->fraction_z);
> + of_property_read_u32(np, "st,i-drive", &ts->i_drive);
NAK.
You just broke it, all the pointers you passed were of type u8 *..
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-24 7:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-24 7:06 [PATCH] Input: smtpe-ts: better way of using of_property_read_u32() Saurabh Sengar
2015-11-24 7:13 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).