From: "Sinclair Yeh" <syeh@vmware.com>
To: x86@kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>, Sinclair Yeh <syeh@vmware.com>,
pv-drivers@vmware.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
linux-graphics-maintainer@vmware.com,
linux-input@vger.kernel.org
Subject: [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros
Date: Fri, 4 Dec 2015 15:19:40 -0800 [thread overview]
Message-ID: <1449271183-1746-4-git-send-email-syeh@vmware.com> (raw)
In-Reply-To: <1449271183-1746-1-git-send-email-syeh@vmware.com>
Updated the VMMOUSE macro to use the new VMW_PORT macro. Doing
this instead of replacing all existing instances of VMWMOUSE
to minimize code change.
Signed-off-by: Sinclair Yeh <syeh@vmware.com>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
Reviewed-by: Alok N Kataria <akataria@vmware.com>
Cc: pv-drivers@vmware.com
Cc: linux-graphics-maintainer@vmware.com
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Cc: virtualization@lists.linux-foundation.org
Cc: linux-input@vger.kernel.org
---
v2:
Instead of replacing existing VMMOUSE defines, only modify enough
to use the new VMW_PORT define.
v3:
Use updated VMWARE_PORT() which requires hypervisor magic as an added
parameter
v4:
Swapped parameters 1 and 2 when calling VMW_PORT because the macro
has been updated
---
drivers/input/mouse/vmmouse.c | 22 +++++++---------------
1 file changed, 7 insertions(+), 15 deletions(-)
diff --git a/drivers/input/mouse/vmmouse.c b/drivers/input/mouse/vmmouse.c
index e272f06..ddb152c 100644
--- a/drivers/input/mouse/vmmouse.c
+++ b/drivers/input/mouse/vmmouse.c
@@ -19,6 +19,7 @@
#include <linux/slab.h>
#include <linux/module.h>
#include <asm/hypervisor.h>
+#include <asm/vmware.h>
#include "psmouse.h"
#include "vmmouse.h"
@@ -84,21 +85,12 @@ struct vmmouse_data {
* implementing the vmmouse protocol. Should never execute on
* bare metal hardware.
*/
-#define VMMOUSE_CMD(cmd, in1, out1, out2, out3, out4) \
-({ \
- unsigned long __dummy1, __dummy2; \
- __asm__ __volatile__ ("inl %%dx" : \
- "=a"(out1), \
- "=b"(out2), \
- "=c"(out3), \
- "=d"(out4), \
- "=S"(__dummy1), \
- "=D"(__dummy2) : \
- "a"(VMMOUSE_PROTO_MAGIC), \
- "b"(in1), \
- "c"(VMMOUSE_PROTO_CMD_##cmd), \
- "d"(VMMOUSE_PROTO_PORT) : \
- "memory"); \
+#define VMMOUSE_CMD(cmd, in1, out1, out2, out3, out4) \
+({ \
+ unsigned long __dummy1 = 0, __dummy2 = 0; \
+ VMW_PORT(VMMOUSE_PROTO_CMD_##cmd, in1, VMMOUSE_PROTO_PORT, \
+ VMMOUSE_PROTO_MAGIC, \
+ out1, out2, out3, out4, __dummy1, __dummy2); \
})
/**
--
1.9.1
next prev parent reply other threads:[~2015-12-04 23:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1449008047-8252-1-git-send-email-syeh@vmware.com>
[not found] ` <1449008332-9394-1-git-send-email-syeh@vmware.com>
2015-12-01 22:18 ` [PATCH 3/6] Input: Update vmmouse.c to use the common VMW_PORT macros Sinclair Yeh
2015-12-01 22:24 ` Dmitry Torokhov
2015-12-01 22:32 ` Sinclair Yeh
2015-12-01 22:45 ` Dmitry Torokhov
2015-12-01 22:54 ` Sinclair Yeh
2015-12-01 23:56 ` Dmitry Torokhov
2015-12-02 0:04 ` Greg Kroah-Hartman
2015-12-02 2:21 ` Sinclair Yeh
2015-12-02 15:31 ` Greg Kroah-Hartman
2015-12-02 15:57 ` Sinclair Yeh
2015-12-02 17:26 ` Dmitry Torokhov
2015-12-02 17:29 ` [Linux-graphics-maintainer] " Thomas Hellstrom
2015-12-02 18:45 ` Greg Kroah-Hartman
2015-12-02 18:58 ` Dmitry Torokhov
2015-12-02 19:02 ` Sinclair Yeh
2015-12-02 7:07 ` [Linux-graphics-maintainer] " Thomas Hellstrom
2015-12-02 0:01 ` Greg Kroah-Hartman
[not found] ` <1449271183-1746-1-git-send-email-syeh@vmware.com>
2015-12-04 23:19 ` Sinclair Yeh [this message]
[not found] ` <1453239965-1466-1-git-send-email-syeh@vmware.com>
2016-01-19 21:46 ` Sinclair Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449271183-1746-4-git-send-email-syeh@vmware.com \
--to=syeh@vmware.com \
--cc=arnd@arndb.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).