From: Bastien Nocera <hadess@hadess.net>
To: Priit Laes <plaes@plaes.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-input@vger.kernel.org, Aleksei Mamlin <mamlinav@gmail.com>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1
Date: Tue, 08 Dec 2015 13:14:58 +0100 [thread overview]
Message-ID: <1449576898.28364.16.camel@hadess.net> (raw)
In-Reply-To: <1449473161-3535-3-git-send-email-plaes@plaes.org>
Hey Priit,
On Mon, 2015-12-07 at 09:26 +0200, Priit Laes wrote:
> This patch adds Goodix GT801 2+1 touchscreen controller support.
>
> GT801 2+1 is a 10-finger touch controller consisting of
> ARM controller interfacing two GT801 5-finger controllers.
This would implement support for the "Guitar" protocol used by a few
more variants of the GT80x devices. Can you rename the driver/docs to that effect?
<snip>
> +
> +static const struct i2c_device_id gt801x_ts_id[] = {
> + { "GDIX1001:00", 0 },
This clashes with the ID used in the goodix.c driver.
Cheers
next prev parent reply other threads:[~2015-12-08 12:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 7:25 [PATCH 0/2] input: Driver for Goodix GT801 2+1 touchscreen Priit Laes
[not found] ` <1449473161-3535-1-git-send-email-plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
2015-12-07 7:26 ` [PATCH 1/2] ARM: dts: sun4i: gemei-g9: Add touchscreen (Goodix gt801x2) support Priit Laes
2015-12-07 7:26 ` [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1 Priit Laes
2015-12-08 12:14 ` Bastien Nocera [this message]
2015-12-08 15:18 ` Rob Herring
2015-12-08 12:14 ` [PATCH 0/2] input: Driver for Goodix GT801 2+1 touchscreen Bastien Nocera
[not found] <201512071608.oGt2n0Wn%fengguang.wu@intel.com>
[not found] ` <201512071608.oGt2n0Wn%fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-12-07 8:34 ` [PATCH 2/2] input: gt801_2plus1 - Add initial support for Goodix GT801 2+1 Julia Lawall
2015-12-07 9:10 ` Priit Laes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449576898.28364.16.camel@hadess.net \
--to=hadess@hadess.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mamlinav@gmail.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=plaes@plaes.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).