* [PATCH] hid: add support for Lilliput touchscreen
@ 2015-12-11 19:47 Srinivas Kandagatla
2016-01-21 13:37 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Srinivas Kandagatla @ 2015-12-11 19:47 UTC (permalink / raw)
To: Jiri Kosina
Cc: linux-arm-kernel, linux-kernel, linux-input, Kiran Rudramuni,
Nicolas Dechesne
From: Kiran Rudramuni <kchitrik@codeaurora.org>
This patch adds support to Liliput capacitive touchscreeen.
Signed-off-by: Kiran Rudramuni <kchitrik@codeaurora.org>
Signed-off-by: Nicolas Dechesne <nicolas.dechesne@linaro.org>
---
Hi
This patch has been in my local tree for long time, tested in
various Hackathons. Could you please take this for v4.5.
thanks,
srini
drivers/hid/hid-core.c | 1 +
drivers/hid/hid-ids.h | 4 ++++
drivers/hid/hid-multitouch.c | 5 +++++
3 files changed, 10 insertions(+)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index c6f7a69..4350376 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2051,6 +2051,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
{ HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
+ { HID_USB_DEVICE(USB_VENDOR_ID_LILLIPUT, USB_PROD_ID_LILLIPUT) },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) },
{ HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 9024a3d..f87993f 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -1055,4 +1055,8 @@
#define USB_DEVICE_ID_RAPHNET_2NES2SNES 0x0002
#define USB_DEVICE_ID_RAPHNET_4NES4SNES 0x0003
+/* Lilliput Capacitive TouchScreen */
+#define USB_VENDOR_ID_LILLIPUT 0x1391
+#define USB_PROD_ID_LILLIPUT 0x2112
+
#endif
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 3d664d0..580749e 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -1209,6 +1209,11 @@ static const struct hid_device_id mt_devices[] = {
MT_USB_DEVICE(USB_VENDOR_ID_CJTOUCH,
USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0040) },
+ /* Lilliput multitouch panels */
+ { .driver_data = MT_CLS_DEFAULT,
+ HID_USB_DEVICE(USB_VENDOR_ID_LILLIPUT,
+ USB_PROD_ID_LILLIPUT) },
+
/* CVTouch panels */
{ .driver_data = MT_CLS_NSMU,
MT_USB_DEVICE(USB_VENDOR_ID_CVTOUCH,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] hid: add support for Lilliput touchscreen
2015-12-11 19:47 [PATCH] hid: add support for Lilliput touchscreen Srinivas Kandagatla
@ 2016-01-21 13:37 ` Jiri Kosina
2016-01-22 22:39 ` Benjamin Tissoires
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2016-01-21 13:37 UTC (permalink / raw)
To: Srinivas Kandagatla
Cc: linux-arm-kernel, linux-kernel, linux-input, Kiran Rudramuni,
Nicolas Dechesne
On Fri, 11 Dec 2015, Srinivas Kandagatla wrote:
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index c6f7a69..4350376 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2051,6 +2051,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
> { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
> + { HID_USB_DEVICE(USB_VENDOR_ID_LILLIPUT, USB_PROD_ID_LILLIPUT) },
Could you please keep the list sorted?
>
> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) },
> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE) },
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 9024a3d..f87993f 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -1055,4 +1055,8 @@
> #define USB_DEVICE_ID_RAPHNET_2NES2SNES 0x0002
> #define USB_DEVICE_ID_RAPHNET_4NES4SNES 0x0003
>
> +/* Lilliput Capacitive TouchScreen */
> +#define USB_VENDOR_ID_LILLIPUT 0x1391
> +#define USB_PROD_ID_LILLIPUT 0x2112
> +
> #endif
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 3d664d0..580749e 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -1209,6 +1209,11 @@ static const struct hid_device_id mt_devices[] = {
> MT_USB_DEVICE(USB_VENDOR_ID_CJTOUCH,
> USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0040) },
>
> + /* Lilliput multitouch panels */
> + { .driver_data = MT_CLS_DEFAULT,
> + HID_USB_DEVICE(USB_VENDOR_ID_LILLIPUT,
> + USB_PROD_ID_LILLIPUT) },
> +
This is a bit out of order as well.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] hid: add support for Lilliput touchscreen
2016-01-21 13:37 ` Jiri Kosina
@ 2016-01-22 22:39 ` Benjamin Tissoires
0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2016-01-22 22:39 UTC (permalink / raw)
To: Jiri Kosina
Cc: Srinivas Kandagatla, linux-arm-kernel,
linux-kernel@vger.kernel.org, linux-input, Kiran Rudramuni,
Nicolas Dechesne
On Thu, Jan 21, 2016 at 2:37 PM, Jiri Kosina <jikos@kernel.org> wrote:
> On Fri, 11 Dec 2015, Srinivas Kandagatla wrote:
>
>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>> index c6f7a69..4350376 100644
>> --- a/drivers/hid/hid-core.c
>> +++ b/drivers/hid/hid-core.c
>> @@ -2051,6 +2051,7 @@ static const struct hid_device_id hid_have_special_driver[] = {
>> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0005) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_ZEROPLUS, 0x0030) },
>> { HID_USB_DEVICE(USB_VENDOR_ID_ZYDACRON, USB_DEVICE_ID_ZYDACRON_REMOTE_CONTROL) },
>> + { HID_USB_DEVICE(USB_VENDOR_ID_LILLIPUT, USB_PROD_ID_LILLIPUT) },
>
> Could you please keep the list sorted?
>
>>
>> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_MICROSOFT, USB_DEVICE_ID_MS_PRESENTER_8K_BT) },
>> { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE) },
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> index 9024a3d..f87993f 100644
>> --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -1055,4 +1055,8 @@
>> #define USB_DEVICE_ID_RAPHNET_2NES2SNES 0x0002
>> #define USB_DEVICE_ID_RAPHNET_4NES4SNES 0x0003
>>
>> +/* Lilliput Capacitive TouchScreen */
>> +#define USB_VENDOR_ID_LILLIPUT 0x1391
>> +#define USB_PROD_ID_LILLIPUT 0x2112
>> +
>> #endif
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 3d664d0..580749e 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -1209,6 +1209,11 @@ static const struct hid_device_id mt_devices[] = {
>> MT_USB_DEVICE(USB_VENDOR_ID_CJTOUCH,
>> USB_DEVICE_ID_CJTOUCH_MULTI_TOUCH_0040) },
>>
>> + /* Lilliput multitouch panels */
>> + { .driver_data = MT_CLS_DEFAULT,
NACK without further explanations.
Why do you need to patch the kernel an already working touchscreen?
MT_CLS_DEFAULT is the default as its name stands, and we do not need
to add a per device entry for it.
Cheers,
Benjamin
>> + HID_USB_DEVICE(USB_VENDOR_ID_LILLIPUT,
>> + USB_PROD_ID_LILLIPUT) },
>> +
>
> This is a bit out of order as well.
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-22 22:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-11 19:47 [PATCH] hid: add support for Lilliput touchscreen Srinivas Kandagatla
2016-01-21 13:37 ` Jiri Kosina
2016-01-22 22:39 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).