From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Nocera Subject: Re: [PATCH 1/2] HID: Use multitouch driver for Type Covers Date: Mon, 14 Dec 2015 14:22:48 +0100 Message-ID: <1450099368.3358.5.camel@hadess.net> References: <1450097429-4959-1-git-send-email-akihiko.odaki.4i@stu.hosei.ac.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52140 "EHLO relay4-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752842AbbLNNWy (ORCPT ); Mon, 14 Dec 2015 08:22:54 -0500 In-Reply-To: <1450097429-4959-1-git-send-email-akihiko.odaki.4i@stu.hosei.ac.jp> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Akihiko Odaki , jikos@kernel.org, Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org On Mon, 2015-12-14 at 21:50 +0900, Akihiko Odaki wrote: > Use multitouch driver instead of microsoft one for Microsoft Surface > Type Covers. > > By using MT_CLS_EXPORT_ALL_INPUTS, the keyboards function as well as > the multitouch pads do. I've discussed this a couple of weeks back with Benjamin Tissoires, and this patch would break the special keys (mute, brightness up/down, keyboard backlight up/down and play/pause). The recommended way to fix this was to move multi-touch processing into the Microsoft driver, so that it would handle the trackpad's multi- touch events. You should be able to do this by carefully picking up the handling code from hid-multitouch, or do something similar to what's done in hid- wacom, which has the same problem as the Type Cover handling. Can you confirm that this does indeed break those special keys? If it does, it's a NAK from my side. Cheers