* [PATCH] HID: corsair: Convert to use module_hid_driver
@ 2015-12-16 8:56 Axel Lin
2015-12-20 11:08 ` Clément VUCHENER
2015-12-28 12:12 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2015-12-16 8:56 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Clément Vuchener, Benjamin Tissoires, linux-input
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/hid/hid-corsair.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c
index bcefb9e..5855196 100644
--- a/drivers/hid/hid-corsair.c
+++ b/drivers/hid/hid-corsair.c
@@ -655,18 +655,7 @@ static struct hid_driver corsair_driver = {
.input_mapping = corsair_input_mapping,
};
-static int __init corsair_init(void)
-{
- return hid_register_driver(&corsair_driver);
-}
-
-static void corsair_exit(void)
-{
- hid_unregister_driver(&corsair_driver);
-}
-
-module_init(corsair_init);
-module_exit(corsair_exit);
+module_hid_driver(corsair_driver);
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Clement Vuchener");
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] HID: corsair: Convert to use module_hid_driver
2015-12-16 8:56 [PATCH] HID: corsair: Convert to use module_hid_driver Axel Lin
@ 2015-12-20 11:08 ` Clément VUCHENER
2015-12-28 12:12 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Clément VUCHENER @ 2015-12-20 11:08 UTC (permalink / raw)
To: Axel Lin; +Cc: Jiri Kosina, Benjamin Tissoires, linux-input
2015-12-16 9:56 GMT+01:00 Axel Lin <axel.lin@ingics.com>:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
I am not sure if I am required to ack trivial patches, but no one answered.
I have no preference toward the old or new code. If it is the prefered
way to do that, I have no problem with it.
Acked-by: Clément Vuchener <clement.vuchener@gmail.com>
> ---
> drivers/hid/hid-corsair.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c
> index bcefb9e..5855196 100644
> --- a/drivers/hid/hid-corsair.c
> +++ b/drivers/hid/hid-corsair.c
> @@ -655,18 +655,7 @@ static struct hid_driver corsair_driver = {
> .input_mapping = corsair_input_mapping,
> };
>
> -static int __init corsair_init(void)
> -{
> - return hid_register_driver(&corsair_driver);
> -}
> -
> -static void corsair_exit(void)
> -{
> - hid_unregister_driver(&corsair_driver);
> -}
> -
> -module_init(corsair_init);
> -module_exit(corsair_exit);
> +module_hid_driver(corsair_driver);
>
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Clement Vuchener");
> --
> 2.1.4
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: corsair: Convert to use module_hid_driver
2015-12-16 8:56 [PATCH] HID: corsair: Convert to use module_hid_driver Axel Lin
2015-12-20 11:08 ` Clément VUCHENER
@ 2015-12-28 12:12 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2015-12-28 12:12 UTC (permalink / raw)
To: Axel Lin; +Cc: Clément Vuchener, Benjamin Tissoires, linux-input
On Wed, 16 Dec 2015, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/hid/hid-corsair.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/hid/hid-corsair.c b/drivers/hid/hid-corsair.c
> index bcefb9e..5855196 100644
> --- a/drivers/hid/hid-corsair.c
> +++ b/drivers/hid/hid-corsair.c
> @@ -655,18 +655,7 @@ static struct hid_driver corsair_driver = {
> .input_mapping = corsair_input_mapping,
> };
>
> -static int __init corsair_init(void)
> -{
> - return hid_register_driver(&corsair_driver);
> -}
> -
> -static void corsair_exit(void)
> -{
> - hid_unregister_driver(&corsair_driver);
> -}
> -
> -module_init(corsair_init);
> -module_exit(corsair_exit);
> +module_hid_driver(corsair_driver);
>
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Clement Vuchener");
Applied to for-4.5/upstream.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-28 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-16 8:56 [PATCH] HID: corsair: Convert to use module_hid_driver Axel Lin
2015-12-20 11:08 ` Clément VUCHENER
2015-12-28 12:12 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).