* [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller
@ 2016-01-27 14:09 Stafford Horne
2016-01-27 21:31 ` Jiri Kosina
0 siblings, 1 reply; 5+ messages in thread
From: Stafford Horne @ 2016-01-27 14:09 UTC (permalink / raw)
To: jikos, benjamin.tissoires
Cc: linux-input, linux-kernel, linux-usb, Stafford Horne
The midi controller times-out while initializing reports, this
causes boot to take an extra 10 seconds. The device descriptor
advertises that it has an internal HID device but seems to not
actually do anything useful.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
drivers/hid/hid-ids.h | 3 +++
drivers/hid/usbhid/hid-quirks.c | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index b6ff6e7..3dfb166 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -61,6 +61,9 @@
#define USB_VENDOR_ID_AIREN 0x1a2c
#define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002
+#define USB_VENDOR_ID_AKAI 0x2011
+#define USB_DEVICE_ID_AKAI_MPKMINI2 0x0715
+
#define USB_VENDOR_ID_ALCOR 0x058f
#define USB_DEVICE_ID_ALCOR_USBRS232 0x9720
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 7dd0953..055e740 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -55,6 +55,7 @@ static const struct hid_blacklist {
{ USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
{ USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET },
+ { USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_UC100KM, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_CS124U, HID_QUIRK_NOGET },
{ USB_VENDOR_ID_ATEN, USB_DEVICE_ID_ATEN_2PORTKVM, HID_QUIRK_NOGET },
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller
2016-01-27 14:09 [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller Stafford Horne
@ 2016-01-27 21:31 ` Jiri Kosina
2016-01-27 22:44 ` Stafford Horne
2016-01-28 9:15 ` Oliver Neukum
0 siblings, 2 replies; 5+ messages in thread
From: Jiri Kosina @ 2016-01-27 21:31 UTC (permalink / raw)
To: Stafford Horne; +Cc: benjamin.tissoires, linux-input, linux-kernel, linux-usb
On Wed, 27 Jan 2016, Stafford Horne wrote:
> The midi controller times-out while initializing reports, this
> causes boot to take an extra 10 seconds. The device descriptor
> advertises that it has an internal HID device but seems to not
> actually do anything useful.
>
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
> drivers/hid/hid-ids.h | 3 +++
> drivers/hid/usbhid/hid-quirks.c | 1 +
> 2 files changed, 4 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index b6ff6e7..3dfb166 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -61,6 +61,9 @@
> #define USB_VENDOR_ID_AIREN 0x1a2c
> #define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002
>
> +#define USB_VENDOR_ID_AKAI 0x2011
> +#define USB_DEVICE_ID_AKAI_MPKMINI2 0x0715
> +
> #define USB_VENDOR_ID_ALCOR 0x058f
> #define USB_DEVICE_ID_ALCOR_USBRS232 0x9720
>
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 7dd0953..055e740 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -55,6 +55,7 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
>
> { USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET },
> + { USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS },
If the (proclaimed) HID device is completely silent, wouldn't
HID_QUIRK_IGNORE be more appropriate?
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller
2016-01-27 21:31 ` Jiri Kosina
@ 2016-01-27 22:44 ` Stafford Horne
2016-01-28 9:15 ` Oliver Neukum
1 sibling, 0 replies; 5+ messages in thread
From: Stafford Horne @ 2016-01-27 22:44 UTC (permalink / raw)
To: Jiri Kosina
Cc: Stafford Horne, benjamin.tissoires, linux-input, linux-kernel,
linux-usb
On Wed, 27 Jan 2016, Jiri Kosina wrote:
> On Wed, 27 Jan 2016, Stafford Horne wrote:
>
>> The midi controller times-out while initializing reports, this
>> causes boot to take an extra 10 seconds. The device descriptor
>> advertises that it has an internal HID device but seems to not
>> actually do anything useful.
>>
>> Signed-off-by: Stafford Horne <shorne@gmail.com>
>> ---
>> drivers/hid/hid-ids.h | 3 +++
>> drivers/hid/usbhid/hid-quirks.c | 1 +
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> index b6ff6e7..3dfb166 100644
>> --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -61,6 +61,9 @@
>> #define USB_VENDOR_ID_AIREN 0x1a2c
>> #define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002
>>
>> +#define USB_VENDOR_ID_AKAI 0x2011
>> +#define USB_DEVICE_ID_AKAI_MPKMINI2 0x0715
>> +
>> #define USB_VENDOR_ID_ALCOR 0x058f
>> #define USB_DEVICE_ID_ALCOR_USBRS232 0x9720
>>
>> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
>> index 7dd0953..055e740 100644
>> --- a/drivers/hid/usbhid/hid-quirks.c
>> +++ b/drivers/hid/usbhid/hid-quirks.c
>> @@ -55,6 +55,7 @@ static const struct hid_blacklist {
>> { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
>>
>> { USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET },
>> + { USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS },
>
> If the (proclaimed) HID device is completely silent, wouldn't
> HID_QUIRK_IGNORE be more appropriate?
You are right, I did NO_INIT_REPORTS because thats where the timeout was.
But after further investigation I found that device is silent.
I will change, test and resubmit a new patch version.
-Stafford
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller
2016-01-27 21:31 ` Jiri Kosina
2016-01-27 22:44 ` Stafford Horne
@ 2016-01-28 9:15 ` Oliver Neukum
2016-01-28 10:00 ` Stafford Horne
1 sibling, 1 reply; 5+ messages in thread
From: Oliver Neukum @ 2016-01-28 9:15 UTC (permalink / raw)
To: Jiri Kosina
Cc: Stafford Horne, benjamin.tissoires, linux-input, linux-kernel,
linux-usb
On Wed, 2016-01-27 at 22:31 +0100, Jiri Kosina wrote:
> On Wed, 27 Jan 2016, Stafford Horne wrote:
>
> > The midi controller times-out while initializing reports, this
> > causes boot to take an extra 10 seconds. The device descriptor
> > advertises that it has an internal HID device but seems to not
> > actually do anything useful.
> >
> > Signed-off-by: Stafford Horne <shorne@gmail.com>
> > ---
> > drivers/hid/hid-ids.h | 3 +++
> > drivers/hid/usbhid/hid-quirks.c | 1 +
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> > index b6ff6e7..3dfb166 100644
> > --- a/drivers/hid/hid-ids.h
> > +++ b/drivers/hid/hid-ids.h
> > @@ -61,6 +61,9 @@
> > #define USB_VENDOR_ID_AIREN 0x1a2c
> > #define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002
> >
> > +#define USB_VENDOR_ID_AKAI 0x2011
> > +#define USB_DEVICE_ID_AKAI_MPKMINI2 0x0715
> > +
> > #define USB_VENDOR_ID_ALCOR 0x058f
> > #define USB_DEVICE_ID_ALCOR_USBRS232 0x9720
> >
> > diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> > index 7dd0953..055e740 100644
> > --- a/drivers/hid/usbhid/hid-quirks.c
> > +++ b/drivers/hid/usbhid/hid-quirks.c
> > @@ -55,6 +55,7 @@ static const struct hid_blacklist {
> > { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
> >
> > { USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET },
> > + { USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS },
>
> If the (proclaimed) HID device is completely silent, wouldn't
> HID_QUIRK_IGNORE be more appropriate?
If it really is impossible to use the device.
That quirk would preclude any use you are not aware of with almost
no added benefit. I would take the patch as is.
Regards
Oliver
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller
2016-01-28 9:15 ` Oliver Neukum
@ 2016-01-28 10:00 ` Stafford Horne
0 siblings, 0 replies; 5+ messages in thread
From: Stafford Horne @ 2016-01-28 10:00 UTC (permalink / raw)
To: Oliver Neukum
Cc: Jiri Kosina, Stafford Horne, benjamin.tissoires, linux-input,
linux-kernel, linux-usb
On Thu, 28 Jan 2016, Oliver Neukum wrote:
> On Wed, 2016-01-27 at 22:31 +0100, Jiri Kosina wrote:
>> On Wed, 27 Jan 2016, Stafford Horne wrote:
>>
>>> The midi controller times-out while initializing reports, this
>>> causes boot to take an extra 10 seconds. The device descriptor
>>> advertises that it has an internal HID device but seems to not
>>> actually do anything useful.
>>>
>>> Signed-off-by: Stafford Horne <shorne@gmail.com>
>>> ---
>>> drivers/hid/hid-ids.h | 3 +++
>>> drivers/hid/usbhid/hid-quirks.c | 1 +
>>> 2 files changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>>> index b6ff6e7..3dfb166 100644
>>> --- a/drivers/hid/hid-ids.h
>>> +++ b/drivers/hid/hid-ids.h
>>> @@ -61,6 +61,9 @@
>>> #define USB_VENDOR_ID_AIREN 0x1a2c
>>> #define USB_DEVICE_ID_AIREN_SLIMPLUS 0x0002
>>>
>>> +#define USB_VENDOR_ID_AKAI 0x2011
>>> +#define USB_DEVICE_ID_AKAI_MPKMINI2 0x0715
>>> +
>>> #define USB_VENDOR_ID_ALCOR 0x058f
>>> #define USB_DEVICE_ID_ALCOR_USBRS232 0x9720
>>>
>>> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
>>> index 7dd0953..055e740 100644
>>> --- a/drivers/hid/usbhid/hid-quirks.c
>>> +++ b/drivers/hid/usbhid/hid-quirks.c
>>> @@ -55,6 +55,7 @@ static const struct hid_blacklist {
>>> { USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS, HID_QUIRK_MULTI_INPUT },
>>>
>>> { USB_VENDOR_ID_AIREN, USB_DEVICE_ID_AIREN_SLIMPLUS, HID_QUIRK_NOGET },
>>> + { USB_VENDOR_ID_AKAI, USB_DEVICE_ID_AKAI_MPKMINI2, HID_QUIRK_NO_INIT_REPORTS },
>>
>> If the (proclaimed) HID device is completely silent, wouldn't
>> HID_QUIRK_IGNORE be more appropriate?
>
> If it really is impossible to use the device.
> That quirk would preclude any use you are not aware of with almost
> no added benefit. I would take the patch as is.
That may be right, after having a look at usbhid quirks, no device yet has
HID_QUIRK_IGNORE. Also, I have a feeling the HID enpoints might have some
proprietary functionality.
The defined interface descriptors are 1 HID, 2 Audio Control Device, 3 Audio
MIDI streaming. I tried to write and read from the HID endpoints using
hidraw with no luck. But someone else might figure it out.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-28 10:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27 14:09 [PATCH] HID: quirks: Add no_init_reports for AKAI midi controller Stafford Horne
2016-01-27 21:31 ` Jiri Kosina
2016-01-27 22:44 ` Stafford Horne
2016-01-28 9:15 ` Oliver Neukum
2016-01-28 10:00 ` Stafford Horne
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).