From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [patch] Input: synaptics-rmi4 - using logical instead of bitwise AND Date: Tue, 15 Mar 2016 01:33:29 -0700 Message-ID: <1458030809.11972.178.camel@perches.com> References: <20160315071140.GF13560@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160315071140.GF13560@mwanda> Sender: kernel-janitors-owner@vger.kernel.org To: Dan Carpenter , Dmitry Torokhov , Andrew Duggan Cc: Henrik Rydberg , Christopher Heiny , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org List-Id: linux-input@vger.kernel.org On Tue, 2016-03-15 at 10:11 +0300, Dan Carpenter wrote: > There is a typo so we have && instead of &. >=20 > Fixes: ff8f83708b3e ('Input: synaptics-rmi4 - add support for 2D sens= ors and F11') > Signed-off-by: Dan Carpenter >=20 > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f1= 1.c [] > @@ -775,7 +775,7 @@ static int rmi_f11_get_query_parameters(struct rm= i_device *rmi_dev, > =A0 sensor_query->has_abs =3D !!(query_buf[0] & RMI_F11_HAS_ABS); > =A0 sensor_query->has_gestures =3D !!(query_buf[0] & RMI_F11_HAS_GEST= URES); > =A0 sensor_query->has_sensitivity_adjust =3D > - !!(query_buf[0] && RMI_F11_HAS_SENSITIVITY_ADJ); > + !!(query_buf[0] & RMI_F11_HAS_SENSITIVITY_ADJ); > =A0 sensor_query->configurable =3D !!(query_buf[0] & RMI_F11_CONFIGUR= ABLE); > =A0 > =A0 sensor_query->nr_x_electrodes =3D > @@ -803,7 +803,7 @@ static int rmi_f11_get_query_parameters(struct rm= i_device *rmi_dev, > =A0 sensor_query->has_bending_correction =3D > =A0 !!(query_buf[0] & RMI_F11_HAS_BENDING_CORRECTION); > =A0 sensor_query->has_large_object_suppression =3D > - !!(query_buf[0] && RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > + !!(query_buf[0] & RMI_F11_HAS_LARGE_OBJECT_SUPPRESSION); > =A0 sensor_query->has_jitter_filter =3D > =A0 !!(query_buf[0] & RMI_F11_HAS_JITTER_FILTER); > =A0 query_size++; Right and as well these are bool so the !! isn't necessary. -- To unsubscribe from this list: send the line "unsubscribe kernel-janito= rs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html