[PATCH v2] Documentation: devicetree: Clean up gpio-keys example

[PATCH v2] Documentation: devicetree: Clean up gpio-keys example

[Andreas Färber]

Drop #address-cells and #size-cells, which are not required by the
gpio-keys binding documentation, as button sub-nodes are not devices.

Rename sub-nodes to avoid new dtc unit address warnings when copied.

While at it, adopt the dashes convention for the node name.

Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
Cc: Julien Chauveau <chauveau.julien@gmail.com>
Cc: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v1 -> v2:
 * Changed node name from underscore to dash
 * Inserted white lines
 * Renamed sub-nodes (Geert, Julien)
 
 Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
index 21641236c095..a94940481e55 100644
--- a/Documentation/devicetree/bindings/input/gpio-keys.txt
+++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
@@ -32,17 +32,17 @@ Optional subnode-properties:
 
 Example nodes:
 
-	gpio_keys {
+	gpio-keys {
 			compatible = "gpio-keys";
-			#address-cells = <1>;
-			#size-cells = <0>;
 			autorepeat;
-			button@21 {
+
+			up {
 				label = "GPIO Key UP";
 				linux,code = <103>;
 				gpios = <&gpio1 0 1>;
 			};
-			button@22 {
+
+			down {
 				label = "GPIO Key DOWN";
 				linux,code = <108>;
 				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
-- 
2.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

[Javier Martinez Canillas]

Hello Andreas,

On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
>
> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>
> While at it, adopt the dashes convention for the node name.
>
> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---

Patch looks good to me.

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

[Julien Chauveau]

> Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@dowhile0.org> a écrit :
> 
> Hello Andreas,
> 
> On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>> 
>> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>> 
>> While at it, adopt the dashes convention for the node name.
>> 
>> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
>> Cc: Julien Chauveau <chauveau.julien@gmail.com>
>> Cc: Javier Martinez Canillas <javier@dowhile0.org>
>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
> 
> Patch looks good to me.
> 
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

I agree.

Reviewed-by: Julien Chauveau <chauveau.julien@gmail.com>

Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

[Dmitry Torokhov]

On Wed, Mar 16, 2016 at 10:55:53PM +0100, Julien Chauveau wrote:
> 
> > Le 16 mars 2016 à 15:47, Javier Martinez Canillas <javier@dowhile0.org> a écrit :
> > 
> > Hello Andreas,
> > 
> > On Wed, Mar 16, 2016 at 8:53 AM, Andreas Färber <afaerber@suse.de> wrote:
> >> Drop #address-cells and #size-cells, which are not required by the
> >> gpio-keys binding documentation, as button sub-nodes are not devices.
> >> 
> >> Rename sub-nodes to avoid new dtc unit address warnings when copied.
> >> 
> >> While at it, adopt the dashes convention for the node name.
> >> 
> >> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> >> Cc: Julien Chauveau <chauveau.julien@gmail.com>
> >> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> >> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> >> Signed-off-by: Andreas Färber <afaerber@suse.de>
> >> ---
> > 
> > Patch looks good to me.
> > 
> > Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> I agree.
> 
> Reviewed-by: Julien Chauveau <chauveau.julien@gmail.com>

Applied, thank you.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

[Rob Herring]

On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas Färber wrote:
> Drop #address-cells and #size-cells, which are not required by the
> gpio-keys binding documentation, as button sub-nodes are not devices.
> 
> Rename sub-nodes to avoid new dtc unit address warnings when copied.
> 
> While at it, adopt the dashes convention for the node name.
> 
> Reported-by: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Julien Chauveau <chauveau.julien@gmail.com>
> Cc: Javier Martinez Canillas <javier@dowhile0.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>

Applied, thanks.

Rob

> ---
>  v1 -> v2:
>  * Changed node name from underscore to dash
>  * Inserted white lines
>  * Renamed sub-nodes (Geert, Julien)
>  
>  Documentation/devicetree/bindings/input/gpio-keys.txt | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/input/gpio-keys.txt b/Documentation/devicetree/bindings/input/gpio-keys.txt
> index 21641236c095..a94940481e55 100644
> --- a/Documentation/devicetree/bindings/input/gpio-keys.txt
> +++ b/Documentation/devicetree/bindings/input/gpio-keys.txt
> @@ -32,17 +32,17 @@ Optional subnode-properties:
>  
>  Example nodes:
>  
> -	gpio_keys {
> +	gpio-keys {
>  			compatible = "gpio-keys";
> -			#address-cells = <1>;
> -			#size-cells = <0>;
>  			autorepeat;
> -			button@21 {
> +
> +			up {
>  				label = "GPIO Key UP";
>  				linux,code = <103>;
>  				gpios = <&gpio1 0 1>;
>  			};
> -			button@22 {
> +
> +			down {
>  				label = "GPIO Key DOWN";
>  				linux,code = <108>;
>  				interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>;
> -- 
> 2.6.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] Documentation: devicetree: Clean up gpio-keys example

[Javier Martinez Canillas]

Hello Rob,

On Tue, Apr 19, 2016 at 6:13 PM, Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> On Wed, Mar 16, 2016 at 12:53:29PM +0100, Andreas Färber wrote:
>> Drop #address-cells and #size-cells, which are not required by the
>> gpio-keys binding documentation, as button sub-nodes are not devices.
>>
>> Rename sub-nodes to avoid new dtc unit address warnings when copied.
>>
>> While at it, adopt the dashes convention for the node name.
>>
>> Reported-by: Julien Chauveau <chauveau.julien-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Cc: Julien Chauveau <chauveau.julien-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> Cc: Javier Martinez Canillas <javier-0uQlZySMnqxg9hUCZPvPmw@public.gmane.org>
>> Cc: Geert Uytterhoeven <geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
>> Signed-off-by: Andreas Färber <afaerber-l3A5Bk7waGM@public.gmane.org>
>
> Applied, thanks.
>

Dmitry already applied this patch in the input tree.

> Rob
>

Best regards,
Javier
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html