From: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
To: Henrik Rydberg <rydberg@bitmath.se>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@enac.fr>
Subject: Re: [PATCH] hid: Remove QUANTA from special drivers list
Date: Thu, 23 Aug 2012 11:10:58 +0100 [thread overview]
Message-ID: <1458729.LvjituALLn@f17simon> (raw)
In-Reply-To: <20120822170052.GA6158@polaris.bitmath.org>
[-- Attachment #1: Type: text/plain, Size: 1877 bytes --]
On Wednesday 22 August 2012 19:00:52 Henrik Rydberg wrote:
> > > Applying just this patch is enough to fix the problem I described in my mail
> > > "QUANTA touchscreen controller integrated in HP2310ti no longer recognised
> > > (regression in 3.5 and later as compared to 3.3)".
> > >
> > > This looks like an oversight in commit 4fa3a58; that commit removes most
> > > multitouch screens from this list, but missed this one. Henrik should be
> > > able to confirm, though, so I'd appreciate his sign-off.
>
> Yes, good find. We have two identifiers for the same device,
> USB_DEVICE_ID_PIXART_IMAGING_INC_OPTICAL_TOUCH_SCREEN and
> USB_DEVICE_ID_QUANTA_OPTICAL_TOUCH_3001, which might explain why it
> was overlooked. I think we should get rid of one of them. Also, I
> wonder if the HID_QUIRK_NOGET quirk is still necessary.
>
I'll send a follow-on patch to remove the PIXART_IMAGING identifier. I tried
removing the HID_QURIK_NOGET quirk, but it appears to be needed: without it,
I get:
[ 1.472269] usb 6-1: New USB device found, idVendor=0408, idProduct=3001
[ 1.472275] usb 6-1: New USB device strings: Mfr=1, Product=2, SerialNumber=0
[ 1.472279] usb 6-1: Product: Optical Touch Screen
[ 1.472284] usb 6-1: Manufacturer: QUANTA
<snip>
[ 15.884252] hid-multitouch 0003:0408:3001.0001: usb_submit_urb(ctrl) failed: -1
[ 15.884337] hid-multitouch 0003:0408:3001.0001: timeout initializing reports
[ 15.884584] input: QUANTA Optical Touch Screen as /devices/pci0000:00/0000:00:1d.1/usb6/6-1/6-1:1.0/input/input10
[ 15.884783] hid-multitouch 0003:0408:3001.0001: input,hidraw0: USB HID v1.10 Device [QUANTA Optical Touch Screen] on usb-0000:00:1d.1-1/input0
If I leave the quirk in place, I don't get the 14 second delay, suggesting
that the quirk is needed on this hardware.
--
Simon Farnsworth
Software Engineer
ONELAN Ltd
http://www.onelan.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-08-23 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 10:17 [PATCH] hid: Remove QUANTA from special drivers list Simon Farnsworth
2012-08-22 14:48 ` Jiri Kosina
2012-08-22 17:00 ` Henrik Rydberg
2012-08-23 10:10 ` Simon Farnsworth [this message]
2012-08-23 16:48 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458729.LvjituALLn@f17simon \
--to=simon.farnsworth@onelan.co.uk \
--cc=benjamin.tissoires@enac.fr \
--cc=benjamin.tissoires@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@bitmath.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).