* [PATCH] Input: arizona-haptic - Don't assign input_dev parent
@ 2016-04-15 12:15 Charles Keepax
2016-04-17 12:21 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Charles Keepax @ 2016-04-15 12:15 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, patches
We shouldn't assign the parent device of the input_dev to be the
parent MFD device, because this will be used for devres which causes
input_unregister_device to run after the haptics device has been
removed, since it is itself a child of the MFD device. The default
of using the haptics device itself as the parent is correct.
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
drivers/input/misc/arizona-haptics.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/arizona-haptics.c b/drivers/input/misc/arizona-haptics.c
index d5994a7..9829363 100644
--- a/drivers/input/misc/arizona-haptics.c
+++ b/drivers/input/misc/arizona-haptics.c
@@ -178,7 +178,6 @@ static int arizona_haptics_probe(struct platform_device *pdev)
input_set_drvdata(haptics->input_dev, haptics);
haptics->input_dev->name = "arizona:haptics";
- haptics->input_dev->dev.parent = pdev->dev.parent;
haptics->input_dev->close = arizona_haptics_close;
__set_bit(FF_RUMBLE, haptics->input_dev->ffbit);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: arizona-haptic - Don't assign input_dev parent
2016-04-15 12:15 [PATCH] Input: arizona-haptic - Don't assign input_dev parent Charles Keepax
@ 2016-04-17 12:21 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2016-04-17 12:21 UTC (permalink / raw)
To: Charles Keepax; +Cc: linux-input, patches
On Fri, Apr 15, 2016 at 01:15:49PM +0100, Charles Keepax wrote:
> We shouldn't assign the parent device of the input_dev to be the
> parent MFD device, because this will be used for devres which causes
> input_unregister_device to run after the haptics device has been
> removed, since it is itself a child of the MFD device. The default
> of using the haptics device itself as the parent is correct.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Applied, thank you.
> ---
> drivers/input/misc/arizona-haptics.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/misc/arizona-haptics.c b/drivers/input/misc/arizona-haptics.c
> index d5994a7..9829363 100644
> --- a/drivers/input/misc/arizona-haptics.c
> +++ b/drivers/input/misc/arizona-haptics.c
> @@ -178,7 +178,6 @@ static int arizona_haptics_probe(struct platform_device *pdev)
> input_set_drvdata(haptics->input_dev, haptics);
>
> haptics->input_dev->name = "arizona:haptics";
> - haptics->input_dev->dev.parent = pdev->dev.parent;
> haptics->input_dev->close = arizona_haptics_close;
> __set_bit(FF_RUMBLE, haptics->input_dev->ffbit);
>
> --
> 2.1.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-17 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-15 12:15 [PATCH] Input: arizona-haptic - Don't assign input_dev parent Charles Keepax
2016-04-17 12:21 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).