From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v1 1/1] HID: multitouch: enable touchpad on Surface Book Date: Tue, 10 May 2016 18:04:08 +0300 Message-ID: <1462892648.17131.303.camel@linux.intel.com> References: <1462805821-73087-1-git-send-email-andriy.shevchenko@linux.intel.com> <20160510142132.GP23234@mail.corp.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mga14.intel.com ([192.55.52.115]:60069 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbcEJPDC (ORCPT ); Tue, 10 May 2016 11:03:02 -0400 In-Reply-To: <20160510142132.GP23234@mail.corp.redhat.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Benjamin Tissoires Cc: linux-input@vger.kernel.org, Jiri Kosina , Mika Westerberg On Tue, 2016-05-10 at 16:21 +0200, Benjamin Tissoires wrote: > Hi Andy, >=20 > On May 09 2016 or thereabouts, Andy Shevchenko wrote: > >=20 > > Microsoft Surface Book has HID multitouch connected device. Enable > > it here. > >=20 > > The change has been tested on bare metal by reading raw data from > > /dev/input/event4. > >=20 > > The patch uses HID device ID submitted earlier here: > > http://marc.info/?l=3Dlinux-input&m=3D146280544721389&w=3D2 > >=20 > > Signed-off-by: Andy Shevchenko > > --- > > =C2=A0drivers/hid/hid-multitouch.c | 5 +++++ > > =C2=A01 file changed, 5 insertions(+) > >=20 > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid- > > multitouch.c > > index c741f5e..c3df02d 100644 > > --- a/drivers/hid/hid-multitouch.c > > +++ b/drivers/hid/hid-multitouch.c > > @@ -1377,6 +1377,11 @@ static const struct hid_device_id > > mt_devices[] =3D { > > =C2=A0 MT_USB_DEVICE(USB_VENDOR_ID_ILITEK, > > =C2=A0 USB_DEVICE_ID_ILITEK_MULTITOUCH) }, > > =C2=A0 > > + /* Microsoft Surface Book */ > > + { .driver_data =3D MT_CLS_EXPORT_ALL_INPUTS, > > + MT_USB_DEVICE(USB_VENDOR_ID_MICROSOFT, > > + USB_DEVICE_ID_MS_SURFACE_BOOK) }, > > + > I am a little bit lost here. In your previous patch, you unset the > group > MULTITOUCH to the USB_DEVICE_ID_MS_SURFACE_BOOK. But here, you bind a > device to it which will never been present according to > http://marc.info/?l=3Dlinux-input&m=3D146280544721389&w=3D2 Yes, that line is redundant. So, the first hunk of that patch should be removed. >=20 > Also, please make sure all features are working on the keyboard > (special > functions/LEDs). Caps Lock LED is not functional. I have no idea yet what drives it. > The good news is I have been sent a Surface 3 with the typecover. So = I > intend to work on either fixing hid-multitouch or enabling multitouch > for hid-microsoft depending on which makes more sense. >=20 > Cheers, > Benjamin >=20 > >=20 > > =C2=A0 /* MosArt panels */ > > =C2=A0 { .driver_data =3D MT_CLS_CONFIDENCE_MINUS_ONE, > > =C2=A0 MT_USB_DEVICE(USB_VENDOR_ID_ASUS, --=20 Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html