From: Martin Herkt <lachs0r@srsfckn.biz>
To: Hans de Goede <hdegoede@redhat.com>, linux-input@vger.kernel.org
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Ulrik De Bie <ulrik.debie-os@e2big.org>,
George Moutsopoulos <gmoutso@yahoo.co.uk>
Subject: Re: [PATCH] input: elantech.c: add more exceptions to fw version signature check
Date: Thu, 28 May 2015 18:50:10 +0200 [thread overview]
Message-ID: <1463627.FQDSaQ0v44@sakuya> (raw)
In-Reply-To: <5567445D.6070700@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
On Thursday 28 May 2015 18:37:49 you wrote:
> This is wrong, the bits of param[0] which define the hw version of
> the touchpads are in the low nibble, so your check will also match
> older touchpads where we do not want to skip the rare check.
Oh, sorry about that. Should have paid more attention.
First time poking the kernel after all :)
> I've attached my patch, which actually checks the low nibble of
> param[0]. It has already been tested on an Asus PU551LA laptop,
> so it should work for your laptop too.
Yes, this works. Thanks!
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 213 bytes --]
prev parent reply other threads:[~2015-05-28 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-28 16:29 [PATCH] input: elantech.c: add more exceptions to fw version signature check Martin Herkt
2015-05-28 16:37 ` Hans de Goede
2015-05-28 16:50 ` Martin Herkt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463627.FQDSaQ0v44@sakuya \
--to=lachs0r@srsfckn.biz \
--cc=dmitry.torokhov@gmail.com \
--cc=gmoutso@yahoo.co.uk \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=ulrik.debie-os@e2big.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox