linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	Daniel Hung-yu Wu <hywu@google.com>
Subject: [PATCH 1/2] Input: atmel captouch depends on i2c
Date: Thu, 19 May 2016 15:52:24 +0200	[thread overview]
Message-ID: <1463665954-3898044-2-git-send-email-arnd@arndb.de> (raw)
In-Reply-To: <1463665954-3898044-1-git-send-email-arnd@arndb.de>

The newly added Atmal captouch driver fails to build when CONFIG_I2C
is disabled:

drivers/input/misc/atmel_captouch.c: In function 'atmel_read':
drivers/input/misc/atmel_captouch.c:115:8: error: implicit declaration of function 'i2c_transfer' [-Werror=implicit-function-declaration]

This adds an explicit Kconfig dependency to prevent the broken
configuration.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: b06d43f7a3db ("Input: add Atmel Captouch Button driver")
---
 drivers/input/misc/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 9c3dfe79d4d4..27d6da0e354a 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -85,6 +85,7 @@ config INPUT_ARIZONA_HAPTICS
 config INPUT_ATMEL_CAPTOUCH
 	tristate "Atmel Capacitive Touch Button Driver"
 	depends on OF || COMPILE_TEST
+	depends on I2C
 	help
 	  Say Y here if an Atmel Capacitive Touch Button device which
 	  implements "captouch" protocol is connected to I2C bus. Typically
-- 
2.7.0

  reply	other threads:[~2016-05-19 13:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 13:52 Input: two merge window build fixes Arnd Bergmann
2016-05-19 13:52 ` Arnd Bergmann [this message]
2016-05-19 13:52 ` [PATCH 2/2] Input: migor-ts: mark PM functions as __maybe_unused Arnd Bergmann
2016-05-19 16:15 ` Input: two merge window build fixes Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463665954-3898044-2-git-send-email-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hywu@google.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).