* [PATCH] Input: tc3589x-keypad - remove stray ')'
@ 2016-05-22 14:20 Clifton Barnes
2016-05-23 13:26 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Clifton Barnes @ 2016-05-22 14:20 UTC (permalink / raw)
To: dmitry.torokhov
Cc: Clifton Barnes, Linus Walleij, Himangi Saraogi, linux-input,
linux-kernel
The end ')' needs to be removed if the macro is ever used or there
would be a compiler error as it does not have a matching '('.
Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
---
drivers/input/keyboard/tc3589x-keypad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tc3589x-keypad.c b/drivers/input/keyboard/tc3589x-keypad.c
index e92dfd8..ec0070e 100644
--- a/drivers/input/keyboard/tc3589x-keypad.c
+++ b/drivers/input/keyboard/tc3589x-keypad.c
@@ -32,7 +32,7 @@
#define TC3589x_PULL_DOWN_MASK 0x1
#define TC3589x_PULL_UP_MASK 0x2
#define TC3589x_PULLUP_ALL_MASK 0xAA
-#define TC3589x_IO_PULL_VAL(index, mask) ((mask)<<((index)%4)*2))
+#define TC3589x_IO_PULL_VAL(index, mask) ((mask)<<((index)%4)*2)
/* Bit masks for IOCFG register */
#define IOCFG_BALLCFG 0x01
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Input: tc3589x-keypad - remove stray ')'
2016-05-22 14:20 [PATCH] Input: tc3589x-keypad - remove stray ')' Clifton Barnes
@ 2016-05-23 13:26 ` Linus Walleij
2016-05-23 22:52 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2016-05-23 13:26 UTC (permalink / raw)
To: Clifton Barnes
Cc: Dmitry Torokhov, Himangi Saraogi, Linux Input,
linux-kernel@vger.kernel.org
On Sun, May 22, 2016 at 4:20 PM, Clifton Barnes
<clifton.a.barnes@gmail.com> wrote:
> The end ')' needs to be removed if the macro is ever used or there
> would be a compiler error as it does not have a matching '('.
>
> Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] Input: tc3589x-keypad - remove stray ')'
2016-05-23 13:26 ` Linus Walleij
@ 2016-05-23 22:52 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2016-05-23 22:52 UTC (permalink / raw)
To: Linus Walleij
Cc: Clifton Barnes, Himangi Saraogi, Linux Input,
linux-kernel@vger.kernel.org
On Mon, May 23, 2016 at 03:26:56PM +0200, Linus Walleij wrote:
> On Sun, May 22, 2016 at 4:20 PM, Clifton Barnes
> <clifton.a.barnes@gmail.com> wrote:
>
> > The end ')' needs to be removed if the macro is ever used or there
> > would be a compiler error as it does not have a matching '('.
> >
> > Signed-off-by: Clifton Barnes <clifton.a.barnes@gmail.com>
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Applied, thank you.
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-23 22:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-22 14:20 [PATCH] Input: tc3589x-keypad - remove stray ')' Clifton Barnes
2016-05-23 13:26 ` Linus Walleij
2016-05-23 22:52 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).