linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dennis Chen <barracks510@gmail.com>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>,
	linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH] HID: multitouch: add support for Type Cover Pro 3
Date: Sat, 25 Jun 2016 00:49:00 -0700	[thread overview]
Message-ID: <1466840940.28419.6.camel@gmail.com> (raw)
In-Reply-To: <20160624071419.GO24234@mail.corp.redhat.com>


[-- Attachment #1.1: Type: text/plain, Size: 798 bytes --]

On Fri, 2016-06-24 at 09:14 +0200, Benjamin Tissoires wrote:
> Looks like the same issue Andy is seeing on the Surface Book. So I
> think my patch must have a bug where it resets the quirks set by
> usbhid. And this is why we are screwed here.
> 

Yes, I think that's likely. There doesn't seem to be an issue most of
the time, so it's not a huge deal. 

> Regarding your disconnect issue, what happens I think is that you
> disconnect it before the timeout of usb_submit_urb(), and so the usb
> layer is stuck trying to access the device and can't access the newly
> plugged one. If you wait enough (initial timeout + new timeout -> 20
> secs), then the device behaves properly again.
> 

That is the behavior I have noticed. Is there any potential fix?

Sincerely,
Dennis Chen

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5755 bytes --]

  reply	other threads:[~2016-06-25  7:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-17 20:47 [PATCH] HID: multitouch: add support for Type Cover Pro 3 Dennis Chen
2016-06-17 21:00 ` Jiri Kosina
2016-06-17 21:11   ` Benjamin Tissoires
2016-06-18 18:53     ` Dennis Chen
2016-06-18 19:45       ` Benjamin Tissoires
2016-06-18 23:13         ` Dennis Chen
2016-06-19 20:48         ` Dennis Chen
2016-06-20  9:59           ` Benjamin Tissoires
2016-06-24  3:38             ` Dennis Chen
2016-06-24  7:14               ` Benjamin Tissoires
2016-06-25  7:49                 ` Dennis Chen [this message]
2016-07-01 14:52                   ` Benjamin Tissoires
2016-07-23 20:13                     ` Dennis Chen
2016-07-25 10:16                       ` Benjamin Tissoires
2016-09-19 16:30                         ` Dennis Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1466840940.28419.6.camel@gmail.com \
    --to=barracks510@gmail.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).