* [PATCH 1/1] input: touchscreen: ts4800-ts: add missing of_node_put after calling of_parse_phandle
@ 2016-07-15 9:32 Peter Chen
2016-07-15 16:32 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Peter Chen @ 2016-07-15 9:32 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: Peter Chen, linux-input, Rob Herring, Damien Riegel
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Cc: linux-input@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>
Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
---
drivers/input/touchscreen/ts4800-ts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/ts4800-ts.c b/drivers/input/touchscreen/ts4800-ts.c
index 3c3dd78..8f27ad8 100644
--- a/drivers/input/touchscreen/ts4800-ts.c
+++ b/drivers/input/touchscreen/ts4800-ts.c
@@ -135,6 +135,7 @@ static int ts4800_parse_dt(struct platform_device *pdev,
ts->bit = BIT(bit);
ts->regmap = syscon_node_to_regmap(syscon_np);
+ of_node_put(syscon_np);
if (IS_ERR(ts->regmap)) {
dev_err(dev, "cannot get parent's regmap\n");
return PTR_ERR(ts->regmap);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/1] input: touchscreen: ts4800-ts: add missing of_node_put after calling of_parse_phandle
2016-07-15 9:32 [PATCH 1/1] input: touchscreen: ts4800-ts: add missing of_node_put after calling of_parse_phandle Peter Chen
@ 2016-07-15 16:32 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2016-07-15 16:32 UTC (permalink / raw)
To: Peter Chen; +Cc: linux-input, Rob Herring, Damien Riegel
On Fri, Jul 15, 2016 at 05:32:05PM +0800, Peter Chen wrote:
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Cc: linux-input@vger.kernel.org
> Cc: Rob Herring <robh@kernel.org>
> Cc: Damien Riegel <damien.riegel@savoirfairelinux.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
> drivers/input/touchscreen/ts4800-ts.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/ts4800-ts.c b/drivers/input/touchscreen/ts4800-ts.c
> index 3c3dd78..8f27ad8 100644
> --- a/drivers/input/touchscreen/ts4800-ts.c
> +++ b/drivers/input/touchscreen/ts4800-ts.c
> @@ -135,6 +135,7 @@ static int ts4800_parse_dt(struct platform_device *pdev,
> ts->bit = BIT(bit);
>
> ts->regmap = syscon_node_to_regmap(syscon_np);
> + of_node_put(syscon_np);
This does not help with the other 2 "returns" above which also leak the
reference count. I'll switch the code around and apply.
> if (IS_ERR(ts->regmap)) {
> dev_err(dev, "cannot get parent's regmap\n");
> return PTR_ERR(ts->regmap);
> --
> 1.9.1
>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-15 16:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-15 9:32 [PATCH 1/1] input: touchscreen: ts4800-ts: add missing of_node_put after calling of_parse_phandle Peter Chen
2016-07-15 16:32 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).