From: Brian Norris <briannorris@chromium.org>
To: Lee Jones <lee.jones@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Olof Johansson <olof@lixom.net>,
Brian Norris <computersforpeace@gmail.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Enric Balletbo <enric.balletbo@collabora.co.uk>,
Shawn Nematbakhsh <shawnn@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-input@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Brian Norris <briannorris@chromium.org>
Subject: [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer()
Date: Mon, 25 Jul 2016 11:14:10 -0700 [thread overview]
Message-ID: <1469470451-111822-2-git-send-email-briannorris@chromium.org> (raw)
In-Reply-To: <1469470451-111822-1-git-send-email-briannorris@chromium.org>
cros_ec_cmd_xfer returns success status if the command transport
completes successfully, but the execution result is incorrectly ignored.
In many cases, the execution result is assumed to be successful, leading
to ignored errors and operating on uninitialized data.
We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these
problems. Let's use it.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
index a0d95ff682ae..2d5ff86398d0 100644
--- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
+++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
@@ -215,7 +215,7 @@ static int ec_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg i2c_msgs[],
msg->outsize = request_len;
msg->insize = response_len;
- result = cros_ec_cmd_xfer(bus->ec, msg);
+ result = cros_ec_cmd_xfer_status(bus->ec, msg);
if (result < 0) {
dev_err(dev, "Error transferring EC i2c message %d\n", result);
goto exit;
--
2.8.0.rc3.226.g39d4020
next prev parent reply other threads:[~2016-07-25 18:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-25 18:14 [PATCH 0/2] cros_ec: utilize cros_ec_cmd_xfer_status() Brian Norris
2016-07-25 18:14 ` Brian Norris [this message]
2016-07-25 18:31 ` [PATCH 1/2] i2c: cros-ec-tunnel: Fix usage of cros_ec_cmd_xfer() kbuild test robot
2016-07-25 19:45 ` Javier Martinez Canillas
2016-07-25 20:43 ` Wolfram Sang
2016-07-25 20:48 ` Brian Norris
2016-07-26 9:14 ` Thierry Reding
2016-07-26 18:38 ` Brian Norris
2016-07-28 14:15 ` Thierry Reding
2016-07-25 18:14 ` [PATCH 2/2] Input: cros_ec_keyb - " Brian Norris
2016-07-25 18:28 ` Dmitry Torokhov
2016-07-25 18:38 ` kbuild test robot
2016-07-25 19:46 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1469470451-111822-2-git-send-email-briannorris@chromium.org \
--to=briannorris@chromium.org \
--cc=computersforpeace@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=enric.balletbo@collabora.co.uk \
--cc=gwendal@chromium.org \
--cc=javier@osg.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=olof@lixom.net \
--cc=shawnn@chromium.org \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).