From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: [RFC v0 8/8] iwl4965: use firmware_stat instead of completion Date: Thu, 28 Jul 2016 09:55:12 +0200 Message-ID: <1469692512-16863-9-git-send-email-wagi@monom.org> References: <1469692512-16863-1-git-send-email-wagi@monom.org> Return-path: In-Reply-To: <1469692512-16863-1-git-send-email-wagi@monom.org> Sender: linux-kernel-owner@vger.kernel.org To: Bastien Nocera , Bjorn Andersson , Dmitry Torokhov , Greg Kroah-Hartman , Johannes Berg , Kalle Valo , Ohad Ben-Cohen Cc: linux-input@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Wagner List-Id: linux-input@vger.kernel.org From: Daniel Wagner Loading firmware is an operation many drivers implement in various ways around the completion API. And most of them do it almost in the same way. Let's reuse the firmware_stat API which is used also by the firmware_class loader. Apart of streamlining the firmware loading states we also document it slightly better. Signed-off-by: Daniel Wagner --- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 8 ++++---- drivers/net/wireless/intel/iwlegacy/common.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlegacy/4965-mac.c b/drivers/net/wireless/intel/iwlegacy/4965-mac.c index a91d170..d5e5808 100644 --- a/drivers/net/wireless/intel/iwlegacy/4965-mac.c +++ b/drivers/net/wireless/intel/iwlegacy/4965-mac.c @@ -5005,7 +5005,7 @@ il4965_ucode_callback(const struct firmware *ucode_raw, void *context) /* We have our copies now, allow OS release its copies */ release_firmware(ucode_raw); - complete(&il->_4965.firmware_loading_complete); + fw_loading_done(il->_4965.fw_st); return; try_again: @@ -5019,7 +5019,7 @@ err_pci_alloc: IL_ERR("failed to allocate pci memory\n"); il4965_dealloc_ucode_pci(il); out_unbind: - complete(&il->_4965.firmware_loading_complete); + fw_loading_done(il->_4965.fw_st); device_release_driver(&il->pci_dev->dev); release_firmware(ucode_raw); } @@ -6678,7 +6678,7 @@ il4965_pci_probe(struct pci_dev *pdev, const struct pci_device_id *ent) il_power_initialize(il); - init_completion(&il->_4965.firmware_loading_complete); + firmware_stat_init(&il->_4965.fw_st); err = il4965_request_firmware(il, true); if (err) @@ -6716,7 +6716,7 @@ il4965_pci_remove(struct pci_dev *pdev) if (!il) return; - wait_for_completion(&il->_4965.firmware_loading_complete); + fw_loading_wait(il->_4965.fw_st); D_INFO("*** UNLOAD DRIVER ***\n"); diff --git a/drivers/net/wireless/intel/iwlegacy/common.h b/drivers/net/wireless/intel/iwlegacy/common.h index 726ede3..94af7b7 100644 --- a/drivers/net/wireless/intel/iwlegacy/common.h +++ b/drivers/net/wireless/intel/iwlegacy/common.h @@ -32,6 +32,7 @@ #include #include #include +#include #include #include @@ -1357,7 +1358,7 @@ struct il_priv { bool last_phy_res_valid; u32 ampdu_ref; - struct completion firmware_loading_complete; + struct firmware_stat fw_st; /* * chain noise reset and gain commands are the -- 2.7.4