From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Norris Subject: [RESEND PATCH 2/2] Input: cros_ec_keyb - Fix usage of cros_ec_cmd_xfer() Date: Wed, 10 Aug 2016 13:37:19 -0700 Message-ID: <1470861439-129201-3-git-send-email-briannorris@chromium.org> References: <1470861439-129201-1-git-send-email-briannorris@chromium.org> Return-path: In-Reply-To: <1470861439-129201-1-git-send-email-briannorris@chromium.org> Sender: stable-owner@vger.kernel.org To: Dmitry Torokhov , Wolfram Sang Cc: Lee Jones , Thierry Reding , Olof Johansson , Brian Norris , Javier Martinez Canillas , Enric Balletbo , Shawn Nematbakhsh , Gwendal Grignou , Tomeu Vizoso , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Guenter Roeck , Brian Norris , "# 9798ac6d32c1 mfd : cros_ec : Add cros_ec_cmd_xfer_status helper" List-Id: linux-input@vger.kernel.org cros_ec_cmd_xfer returns success status if the command transport completes successfully, but the execution result is incorrectly ignored. In many cases, the execution result is assumed to be successful, leading to ignored errors and operating on uninitialized data. We've recently introduced the cros_ec_cmd_xfer_status() helper to avoid these problems. Let's use it. [Regarding the 'Fixes' tag; there is significant refactoring since the driver's introduction, but the underlying logical error exists throughout I believe] Fixes: 6af6dc2d2aa6 ("input: Add ChromeOS EC keyboard driver") Cc: # 9798ac6d32c1 mfd: cros_ec: Add cros_ec_cmd_xfer_status() helper Signed-off-by: Brian Norris Reviewed-by: Javier Martinez Canillas Acked-by: Dmitry Torokhov --- drivers/input/keyboard/cros_ec_keyb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/keyboard/cros_ec_keyb.c b/drivers/input/keyboard/cros_ec_keyb.c index b01966dc7eb3..6e48616a3a88 100644 --- a/drivers/input/keyboard/cros_ec_keyb.c +++ b/drivers/input/keyboard/cros_ec_keyb.c @@ -160,7 +160,7 @@ static int cros_ec_keyb_get_state(struct cros_ec_keyb *ckdev, uint8_t *kb_state) msg->insize = ckdev->cols; msg->outsize = 0; - ret = cros_ec_cmd_xfer(ckdev->ec, msg); + ret = cros_ec_cmd_xfer_status(ckdev->ec, msg); if (ret < 0) { dev_err(ckdev->dev, "Error transferring EC message %d\n", ret); goto exit; -- 2.8.0.rc3.226.g39d4020