* [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data
@ 2016-08-17 13:22 LABBE Corentin
2016-08-17 13:22 ` [PATCH 2/3] input: pixcir_i2c: Remove text about writing to Free Software Foundation LABBE Corentin
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: LABBE Corentin @ 2016-08-17 13:22 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, LABBE Corentin
The usage of of_device_get_match_data reduce the code size a bit.
Furthermore, it is better to use a standard function for
getting the match data.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
index d159e14..b0a2dc2 100644
--- a/drivers/input/touchscreen/pixcir_i2c_ts.c
+++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
@@ -431,13 +431,7 @@ static const struct of_device_id pixcir_of_match[];
static int pixcir_parse_dt(struct device *dev,
struct pixcir_i2c_ts_data *tsdata)
{
- const struct of_device_id *match;
-
- match = of_match_device(of_match_ptr(pixcir_of_match), dev);
- if (!match)
- return -EINVAL;
-
- tsdata->chip = (const struct pixcir_i2c_chip_data *)match->data;
+ tsdata->chip = of_device_get_match_data(dev);
if (!tsdata->chip)
return -EINVAL;
--
2.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/3] input: pixcir_i2c: Remove text about writing to Free Software Foundation
2016-08-17 13:22 [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data LABBE Corentin
@ 2016-08-17 13:22 ` LABBE Corentin
2016-08-19 17:17 ` Dmitry Torokhov
2016-08-17 13:22 ` [PATCH 3/3] input: pixcir_i2c: Remove a useless blank line LABBE Corentin
2016-08-19 17:17 ` [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data Dmitry Torokhov
2 siblings, 1 reply; 6+ messages in thread
From: LABBE Corentin @ 2016-08-17 13:22 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, LABBE Corentin
Checkpatch complains about the text suggesting writing to
Free Software Foundation for GPLv2 license copy.
This patch remove that text.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
index b0a2dc2..d8b8889 100644
--- a/drivers/input/touchscreen/pixcir_i2c_ts.c
+++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
@@ -11,10 +11,6 @@
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public
- * License along with this library; if not, write to the Free Software
- * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/
#include <linux/delay.h>
--
2.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 2/3] input: pixcir_i2c: Remove text about writing to Free Software Foundation
2016-08-17 13:22 ` [PATCH 2/3] input: pixcir_i2c: Remove text about writing to Free Software Foundation LABBE Corentin
@ 2016-08-19 17:17 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2016-08-19 17:17 UTC (permalink / raw)
To: LABBE Corentin; +Cc: linux-input, linux-kernel
On Wed, Aug 17, 2016 at 03:22:13PM +0200, LABBE Corentin wrote:
> Checkpatch complains about the text suggesting writing to
> Free Software Foundation for GPLv2 license copy.
> This patch remove that text.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index b0a2dc2..d8b8889 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -11,10 +11,6 @@
> * but WITHOUT ANY WARRANTY; without even the implied warranty of
> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> * GNU General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public
> - * License along with this library; if not, write to the Free Software
> - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> */
>
> #include <linux/delay.h>
> --
> 2.7.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 3/3] input: pixcir_i2c: Remove a useless blank line
2016-08-17 13:22 [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data LABBE Corentin
2016-08-17 13:22 ` [PATCH 2/3] input: pixcir_i2c: Remove text about writing to Free Software Foundation LABBE Corentin
@ 2016-08-17 13:22 ` LABBE Corentin
2016-08-19 17:19 ` Dmitry Torokhov
2016-08-19 17:17 ` [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data Dmitry Torokhov
2 siblings, 1 reply; 6+ messages in thread
From: LABBE Corentin @ 2016-08-17 13:22 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, LABBE Corentin
This patch fix the following checkpatch report:
Blank lines aren't necessary after an open brace
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/input/touchscreen/pixcir_i2c_ts.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
index d8b8889..3bb0637 100644
--- a/drivers/input/touchscreen/pixcir_i2c_ts.c
+++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
@@ -400,7 +400,6 @@ static int __maybe_unused pixcir_i2c_ts_resume(struct device *dev)
mutex_lock(&input->mutex);
if (device_may_wakeup(&client->dev)) {
-
if (!input->users) {
ret = pixcir_stop(ts);
if (ret) {
--
2.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3/3] input: pixcir_i2c: Remove a useless blank line
2016-08-17 13:22 ` [PATCH 3/3] input: pixcir_i2c: Remove a useless blank line LABBE Corentin
@ 2016-08-19 17:19 ` Dmitry Torokhov
0 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2016-08-19 17:19 UTC (permalink / raw)
To: LABBE Corentin; +Cc: linux-input, linux-kernel
On Wed, Aug 17, 2016 at 03:22:14PM +0200, LABBE Corentin wrote:
> This patch fix the following checkpatch report:
> Blank lines aren't necessary after an open brace
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Hmm, OK.
Applied, thank you.
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index d8b8889..3bb0637 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -400,7 +400,6 @@ static int __maybe_unused pixcir_i2c_ts_resume(struct device *dev)
> mutex_lock(&input->mutex);
>
> if (device_may_wakeup(&client->dev)) {
> -
> if (!input->users) {
> ret = pixcir_stop(ts);
> if (ret) {
> --
> 2.7.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data
2016-08-17 13:22 [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data LABBE Corentin
2016-08-17 13:22 ` [PATCH 2/3] input: pixcir_i2c: Remove text about writing to Free Software Foundation LABBE Corentin
2016-08-17 13:22 ` [PATCH 3/3] input: pixcir_i2c: Remove a useless blank line LABBE Corentin
@ 2016-08-19 17:17 ` Dmitry Torokhov
2 siblings, 0 replies; 6+ messages in thread
From: Dmitry Torokhov @ 2016-08-19 17:17 UTC (permalink / raw)
To: LABBE Corentin; +Cc: linux-input, linux-kernel
On Wed, Aug 17, 2016 at 03:22:12PM +0200, LABBE Corentin wrote:
> The usage of of_device_get_match_data reduce the code size a bit.
> Furthermore, it is better to use a standard function for
> getting the match data.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/pixcir_i2c_ts.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchscreen/pixcir_i2c_ts.c
> index d159e14..b0a2dc2 100644
> --- a/drivers/input/touchscreen/pixcir_i2c_ts.c
> +++ b/drivers/input/touchscreen/pixcir_i2c_ts.c
> @@ -431,13 +431,7 @@ static const struct of_device_id pixcir_of_match[];
> static int pixcir_parse_dt(struct device *dev,
> struct pixcir_i2c_ts_data *tsdata)
> {
> - const struct of_device_id *match;
> -
> - match = of_match_device(of_match_ptr(pixcir_of_match), dev);
> - if (!match)
> - return -EINVAL;
> -
> - tsdata->chip = (const struct pixcir_i2c_chip_data *)match->data;
> + tsdata->chip = of_device_get_match_data(dev);
> if (!tsdata->chip)
> return -EINVAL;
>
> --
> 2.7.3
>
--
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-08-19 17:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-17 13:22 [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data LABBE Corentin
2016-08-17 13:22 ` [PATCH 2/3] input: pixcir_i2c: Remove text about writing to Free Software Foundation LABBE Corentin
2016-08-19 17:17 ` Dmitry Torokhov
2016-08-17 13:22 ` [PATCH 3/3] input: pixcir_i2c: Remove a useless blank line LABBE Corentin
2016-08-19 17:19 ` Dmitry Torokhov
2016-08-19 17:17 ` [PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).