* [PATCH -next] HID: intel_ish-hid: Convert list_for_each to entry variant
@ 2016-08-21 15:29 Wei Yongjun
2016-08-26 18:58 ` Srinivas Pandruvada
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2016-08-21 15:29 UTC (permalink / raw)
To: Srinivas Pandruvada, Jiri Kosina, Benjamin Tissoires
Cc: Wei Yongjun, linux-input
convert list_for_each() to list_for_each_entry() where
applicable.
Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
---
drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
index 0183eac..8a1bb8c 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -380,11 +380,9 @@ static struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
struct ishtp_cl_device *device;
int status;
unsigned long flags;
- struct list_head *pos;
spin_lock_irqsave(&dev->device_list_lock, flags);
- list_for_each(pos, &dev->device_list) {
- device = list_entry(pos, struct ishtp_cl_device, device_link);
+ list_for_each_entry(device, &dev->device_list, device_link) {
if (!strcmp(name, dev_name(&device->dev))) {
device->fw_client = &dev->fw_clients[
dev->fw_client_presentation_num - 1];
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] HID: intel_ish-hid: Convert list_for_each to entry variant
2016-08-21 15:29 [PATCH -next] HID: intel_ish-hid: Convert list_for_each to entry variant Wei Yongjun
@ 2016-08-26 18:58 ` Srinivas Pandruvada
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Pandruvada @ 2016-08-26 18:58 UTC (permalink / raw)
To: Wei Yongjun, Jiri Kosina, Benjamin Tissoires; +Cc: linux-input
On Sun, 2016-08-21 at 15:29 +0000, Wei Yongjun wrote:
> convert list_for_each() to list_for_each_entry() where
> applicable.
>
> Signed-off-by: Wei Yongjun <weiyj.lk@gmail.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c
> b/drivers/hid/intel-ish-hid/ishtp/bus.c
> index 0183eac..8a1bb8c 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/bus.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
> @@ -380,11 +380,9 @@ static struct ishtp_cl_device
> *ishtp_bus_add_device(struct ishtp_device *dev,
> struct ishtp_cl_device *device;
> int status;
> unsigned long flags;
> - struct list_head *pos;
>
> spin_lock_irqsave(&dev->device_list_lock, flags);
> - list_for_each(pos, &dev->device_list) {
> - device = list_entry(pos, struct ishtp_cl_device,
> device_link);
> + list_for_each_entry(device, &dev->device_list, device_link)
> {
> if (!strcmp(name, dev_name(&device->dev))) {
> device->fw_client = &dev->fw_clients[
> dev->fw_client_presentation_num -
> 1];
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-26 18:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-21 15:29 [PATCH -next] HID: intel_ish-hid: Convert list_for_each to entry variant Wei Yongjun
2016-08-26 18:58 ` Srinivas Pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).