From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Pandruvada Subject: Re: [PATCH] iio: light and pressure: change data fields for ambient light and pressure sensor Date: Thu, 03 Nov 2016 06:35:44 -0700 Message-ID: <1478180144.27477.3.camel@linux.intel.com> References: <1478169814-24120-1-git-send-email-joyce.ooi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mga01.intel.com ([192.55.52.88]:62012 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbcKCNfs (ORCPT ); Thu, 3 Nov 2016 09:35:48 -0400 In-Reply-To: <1478169814-24120-1-git-send-email-joyce.ooi@intel.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: "Ooi, Joyce" , Jiri Kosina , Jonathan Cameron Cc: Song Hongyan , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Kweh Hock Leong , Ong Boon Leong , Lay Kuan Loon On Thu, 2016-11-03 at 18:43 +0800, Ooi, Joyce wrote: > Sensitivity Percent Relative is added for ambient light sensor as it > is > used based on HID Sensor Usages specifications. The same patch is submitted by Song Hongyan . We may need new IIO ABI to specify relative percent hyst. Thanks, Srinivas > > Other changes include adding HID_USAGE_SENSOR_LIGHT_ILLUM and > HID_USAGE_SENSOR_ATMOSPHERIC_PRESSURE for ambient light and pressure > sensor respectively to be in sync with HID Sensor Usages > specifications. > > Signed-off-by: Ooi, Joyce > --- >  drivers/iio/light/hid-sensor-als.c      | 10 ++++++++++ >  drivers/iio/pressure/hid-sensor-press.c | 10 ++++++++++ >  include/linux/hid-sensor-ids.h          |  1 + >  3 files changed, 21 insertions(+) > > diff --git a/drivers/iio/light/hid-sensor-als.c > b/drivers/iio/light/hid-sensor-als.c > index 8bb1f90..6f3ca18 100644 > --- a/drivers/iio/light/hid-sensor-als.c > +++ b/drivers/iio/light/hid-sensor-als.c > @@ -252,6 +252,16 @@ static int als_parse_report(struct > platform_device *pdev, >   st->common_attributes.sensitivity.index, >   st- > >common_attributes.sensitivity.report_id); >   } > + if (st->common_attributes.sensitivity.index < 0) { > + sensor_hub_input_get_attribute_info(hsdev, > + HID_FEATURE_REPORT, usage_id, > + HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY > _REL_PCT | > + HID_USAGE_SENSOR_LIGHT_ILLUM, > + &st->common_attributes.sensitivity); > + dev_dbg(&pdev->dev, "Sensitivity index:report > %d:%d\n", > + st->common_attributes.sensitivity.index, > + st- > >common_attributes.sensitivity.report_id); > + } >   return ret; >  } >   > diff --git a/drivers/iio/pressure/hid-sensor-press.c > b/drivers/iio/pressure/hid-sensor-press.c > index 6848d8c..4cbbf88 100644 > --- a/drivers/iio/pressure/hid-sensor-press.c > +++ b/drivers/iio/pressure/hid-sensor-press.c > @@ -249,6 +249,16 @@ static int press_parse_report(struct > platform_device *pdev, >   st->common_attributes.sensitivity.index, >   st- > >common_attributes.sensitivity.report_id); >   } > + if (st->common_attributes.sensitivity.index < 0) { > + sensor_hub_input_get_attribute_info(hsdev, > + HID_FEATURE_REPORT, usage_id, > + HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY > _ABS | > + HID_USAGE_SENSOR_ATMOSPHERIC_PRESSURE, > + &st->common_attributes.sensitivity); > + dev_dbg(&pdev->dev, "Sensitivity index:report > %d:%d\n", > + st->common_attributes.sensitivity.index, > + st- > >common_attributes.sensitivity.report_id); > + } >   return ret; >  } >   > diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid- > sensor-ids.h > index f2ee90a..755f5e2 100644 > --- a/include/linux/hid-sensor-ids.h > +++ b/include/linux/hid-sensor-ids.h > @@ -141,6 +141,7 @@ >  /* Per data field properties */ >  #define HID_USAGE_SENSOR_DATA_MOD_NONE > 0x00 >  #define HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS > 0x1000 > +#define HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_REL_PCT > 0xE000 >   >  /* Power state enumerations */ >  #define HID_USAGE_SENSOR_PROP_POWER_STATE_UNDEFINED_ENUM 0x20 > 0850