public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
* Re: hig_magicmouse HID_BATTERY_QUIRK_IGNORE
       [not found] ` <1E169F84-8B4E-4E63-B9BD-213FBBC1B36E@holtmann.org>
@ 2016-11-22 23:00   ` Jérémy Lal
  2016-11-23  0:24     ` Bastien Nocera
  0 siblings, 1 reply; 3+ messages in thread
From: Jérémy Lal @ 2016-11-22 23:00 UTC (permalink / raw)
  To: linux-input

Hi,
i've been using this patch for a while, as a workaround for
https://bugzilla.kernel.org/show_bug.cgi?id=103631
(mouse freeze when battery reports).

--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -321,6 +321,9 @@
 { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
   USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
   HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
+  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
+    USB_DEVICE_ID_APPLE_MAGICMOUSE),
+    HID_BATTERY_QUIRK_IGNORE },
 { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM,
   USB_DEVICE_ID_ELECOM_BM084),
   HID_BATTERY_QUIRK_IGNORE },


Greetings,
Jérémy


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: hig_magicmouse HID_BATTERY_QUIRK_IGNORE
  2016-11-22 23:00   ` hig_magicmouse HID_BATTERY_QUIRK_IGNORE Jérémy Lal
@ 2016-11-23  0:24     ` Bastien Nocera
  2016-11-23  0:33       ` Jérémy Lal
  0 siblings, 1 reply; 3+ messages in thread
From: Bastien Nocera @ 2016-11-23  0:24 UTC (permalink / raw)
  To: Jérémy Lal, linux-input

On Wed, 2016-11-23 at 00:00 +0100, Jérémy Lal wrote:
> Hi,
> i've been using this patch for a while, as a workaround for
> https://bugzilla.kernel.org/show_bug.cgi?id=103631
> (mouse freeze when battery reports).
> 
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -321,6 +321,9 @@
>  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
>    USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
>    HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
> +  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
> +    USB_DEVICE_ID_APPLE_MAGICMOUSE),
> +    HID_BATTERY_QUIRK_IGNORE },
>  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM,
>    USB_DEVICE_ID_ELECOM_BM084),
>    HID_BATTERY_QUIRK_IGNORE },

Doesn't that also stop the mouse from reporting its battery status?

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: hig_magicmouse HID_BATTERY_QUIRK_IGNORE
  2016-11-23  0:24     ` Bastien Nocera
@ 2016-11-23  0:33       ` Jérémy Lal
  0 siblings, 0 replies; 3+ messages in thread
From: Jérémy Lal @ 2016-11-23  0:33 UTC (permalink / raw)
  To: Bastien Nocera; +Cc: linux-input

2016-11-23 1:24 GMT+01:00 Bastien Nocera <hadess@hadess.net>:
> On Wed, 2016-11-23 at 00:00 +0100, Jérémy Lal wrote:
>> Hi,
>> i've been using this patch for a while, as a workaround for
>> https://bugzilla.kernel.org/show_bug.cgi?id=103631
>> (mouse freeze when battery reports).
>>
>> --- a/drivers/hid/hid-input.c
>> +++ b/drivers/hid/hid-input.c
>> @@ -321,6 +321,9 @@
>>  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
>>    USB_DEVICE_ID_APPLE_ALU_WIRELESS_ANSI),
>>    HID_BATTERY_QUIRK_PERCENT | HID_BATTERY_QUIRK_FEATURE },
>> +  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_APPLE,
>> +    USB_DEVICE_ID_APPLE_MAGICMOUSE),
>> +    HID_BATTERY_QUIRK_IGNORE },
>>  { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_ELECOM,
>>    USB_DEVICE_ID_ELECOM_BM084),
>>    HID_BATTERY_QUIRK_IGNORE },
>
> Doesn't that also stop the mouse from reporting its battery status?

Yes, it does. Still better than having it stop abruptly from time to time.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-23  0:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <CAJxTCxxMvwdrLZnsMsOG4vLDNbYmtdGgAXLofUMLvPvoepTk7Q@mail.gmail.com>
     [not found] ` <1E169F84-8B4E-4E63-B9BD-213FBBC1B36E@holtmann.org>
2016-11-22 23:00   ` hig_magicmouse HID_BATTERY_QUIRK_IGNORE Jérémy Lal
2016-11-23  0:24     ` Bastien Nocera
2016-11-23  0:33       ` Jérémy Lal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox