From: Christopher Heiny <christopherheiny@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Chase Douglas <chasedouglas@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: synaptics - add second variant of two-button clickpad
Date: Thu, 01 Mar 2012 16:59:46 -0800 [thread overview]
Message-ID: <1480064.SeUIWcqsCr@brontomerus.synaptics.com> (raw)
In-Reply-To: <20120301194503.GA3854@core.coreip.homeip.net>
On Thursday, March 01, 2012 11:45:03 AM Dmitry Torokhov wrote:
> On Mon, Feb 20, 2012 at 11:48:12AM +0100, Chase Douglas wrote:
> > On 02/14/2012 05:21 AM, Chase Douglas wrote:
> > > Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
> > > ---
> > > There are two models of Dell netbooks (Inspiron 1011 and 1012 IIRC)
> > > with two-button clickpads that do not match the current two-button
> > > clickpad bit mask. I don't have any docs to tell me which bits are
> > > which, but this bit seems the most probably. For reference, the
> > > caps bits for these netbooks are:
> > >
> > > caps: 0xd04713/0xa40000/0x2a0000
> > >
> > > drivers/input/mouse/synaptics.h | 1 +
> > > 1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/drivers/input/mouse/synaptics.h
> > > b/drivers/input/mouse/synaptics.h index fd26ccc..816d7bd 100644
> > > --- a/drivers/input/mouse/synaptics.h
> > > +++ b/drivers/input/mouse/synaptics.h
> > > @@ -80,6 +80,7 @@
> > >
> > > */
> > >
> > > #define SYN_CAP_CLICKPAD(ex0c) ((ex0c) & 0x100000) /* 1-button
> > > ClickPad */ #define SYN_CAP_CLICKPAD2BTN(ex0c) ((ex0c) &
> > > 0x000100) /* 2-button ClickPad */> >
> > > +#define SYN_CAP_CLICKPAD2BTN2(ex0c) ((ex0c) & 0x200000) /* 2-button
> > > ClickPad */> >
> > > #define SYN_CAP_MAX_DIMENSIONS(ex0c) ((ex0c) & 0x020000)
> > > #define SYN_CAP_MIN_DIMENSIONS(ex0c) ((ex0c) & 0x002000)
> > > #define SYN_CAP_ADV_GESTURE(ex0c) ((ex0c) & 0x080000)
> >
> > Dmitry, would you be able to comment on this soon? We're approaching
> > kernel freeze in Ubuntu and I want to have this patch in there if it
> > makes sense.
>
> According to the data sent by Synaptics (ex0c & 0x60000) identifies
> algorithm used to count fingers, and not device type, at least not
> directly...
>
> Christopher, any insight you could share?
Dmitry - I think you dropped a zero in the mask. If that's the case, then you
are correct, (ex0c & 0x600000) identifies the multifinger mode, independent of
clickpad or not.
Chase - those capability bits look a bit wacky to me. Can you tell me the TM
number or product ID info for those pads?
next prev parent reply other threads:[~2012-03-02 0:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 4:21 [PATCH 1/2] Input: synaptics - add second variant of two-button clickpad Chase Douglas
2012-02-14 4:21 ` [PATCH 2/2] Input: synapticss - Set buttonpad property for all clickpads Chase Douglas
2012-02-20 10:48 ` [PATCH 1/2] Input: synaptics - add second variant of two-button clickpad Chase Douglas
2012-03-01 17:59 ` Chase Douglas
2012-03-01 19:45 ` Dmitry Torokhov
2012-03-02 0:59 ` Christopher Heiny [this message]
2012-03-02 1:18 ` Chase Douglas
2012-03-02 1:27 ` Christopher Heiny
2012-03-13 21:41 ` Chase Douglas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480064.SeUIWcqsCr@brontomerus.synaptics.com \
--to=christopherheiny@gmail.com \
--cc=chasedouglas@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).