From: Jingkui Wang <jkwang@google.com>
To: linux-input@vger.kernel.org
Cc: dmitry.torokhov@gmail.com, Dan Murphy <dmurphy@ti.com>,
Jingkui Wang <jkwang@google.com>
Subject: [PATCH] Input: Driver drv260x.c - fix bug of adding wrong device parent
Date: Mon, 12 Dec 2016 13:37:07 -0800 [thread overview]
Message-ID: <1481578627-56391-1-git-send-email-jkwang@google.com> (raw)
Fix the bug of adding wrong parent to the input_dev created by the
driver. The bug will be triggered if rmmod is called for this driver
module.
Signed-off-by: Jingkui Wang <jkwang@google.com>
---
drivers/input/misc/drv260x.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c
index 4f448ba..885c140 100644
--- a/drivers/input/misc/drv260x.c
+++ b/drivers/input/misc/drv260x.c
@@ -565,7 +565,6 @@ static int drv260x_probe(struct i2c_client *client,
}
haptics->input_dev->name = "drv260x:haptics";
- haptics->input_dev->dev.parent = client->dev.parent;
haptics->input_dev->close = drv260x_close;
input_set_drvdata(haptics->input_dev, haptics);
input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);
--
2.6.6
next reply other threads:[~2016-12-12 21:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 21:37 Jingkui Wang [this message]
2016-12-12 22:05 ` [PATCH] Input: Driver drv260x.c - fix bug of adding wrong device parent Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481578627-56391-1-git-send-email-jkwang@google.com \
--to=jkwang@google.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).