* [PATCH] Input: xpad - use correct product id for x360w controllers
@ 2016-12-27 16:01 Pavel Rojtberg
2016-12-27 19:45 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Rojtberg @ 2016-12-27 16:01 UTC (permalink / raw)
To: linux-input, pgriffais, dmitry.torokhov, gregkh; +Cc: Pavel Rojtberg
From: Pavel Rojtberg <rojtberg@gmail.com>
currently the controllers get the same product id as the wireless
receiver. However the controllers actually have their own product id.
The patch makes the driver expose the same product id as the windows
driver.
This improves compatibility when running applications with WINE.
see https://github.com/paroj/xpad/issues/54
Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
---
drivers/input/joystick/xpad.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index 098d8ec..34a2409 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -1412,6 +1412,12 @@ static int xpad_init_input(struct usb_xpad *xpad)
input_dev->name = xpad->name;
input_dev->phys = xpad->phys;
usb_to_input_id(xpad->udev, &input_dev->id);
+
+ if(xpad->xtype == XTYPE_XBOX360W) {
+ /* x360w controllers and the receiver have different ids */
+ input_dev->id.product = 0x02a1;
+ }
+
input_dev->dev.parent = &xpad->intf->dev;
input_set_drvdata(input_dev, xpad);
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Input: xpad - use correct product id for x360w controllers
2016-12-27 16:01 [PATCH] Input: xpad - use correct product id for x360w controllers Pavel Rojtberg
@ 2016-12-27 19:45 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2016-12-27 19:45 UTC (permalink / raw)
To: Pavel Rojtberg; +Cc: linux-input, pgriffais, gregkh
On Tue, Dec 27, 2016 at 05:01:58PM +0100, Pavel Rojtberg wrote:
> From: Pavel Rojtberg <rojtberg@gmail.com>
>
> currently the controllers get the same product id as the wireless
> receiver. However the controllers actually have their own product id.
>
> The patch makes the driver expose the same product id as the windows
> driver.
>
> This improves compatibility when running applications with WINE.
>
> see https://github.com/paroj/xpad/issues/54
>
> Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
Applied, thank you.
> ---
> drivers/input/joystick/xpad.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 098d8ec..34a2409 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -1412,6 +1412,12 @@ static int xpad_init_input(struct usb_xpad *xpad)
> input_dev->name = xpad->name;
> input_dev->phys = xpad->phys;
> usb_to_input_id(xpad->udev, &input_dev->id);
> +
> + if(xpad->xtype == XTYPE_XBOX360W) {
> + /* x360w controllers and the receiver have different ids */
> + input_dev->id.product = 0x02a1;
> + }
> +
> input_dev->dev.parent = &xpad->intf->dev;
>
> input_set_drvdata(input_dev, xpad);
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-27 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-27 16:01 [PATCH] Input: xpad - use correct product id for x360w controllers Pavel Rojtberg
2016-12-27 19:45 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).