From: Guenter Roeck <linux@roeck-us.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH 4/5] Input: misc/dm355evm_keys - drop unnecessary call to input_set_drvdata
Date: Sun, 22 Jan 2017 16:48:23 -0800 [thread overview]
Message-ID: <1485132505-14562-5-git-send-email-linux@roeck-us.net> (raw)
In-Reply-To: <1485132505-14562-1-git-send-email-linux@roeck-us.net>
Since there is no call to dev_get_drvdata() or input_get_drvdata(),
the call to input_set_drvdata() is unnecessary and can be dropped.
The conversion was done automatically using the following coccinelle
script.
@used@
@@
(
input_get_drvdata(...)
|
dev_get_drvdata(...)
)
@depends on !used@
@@
- input_set_drvdata(...);
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/input/misc/dm355evm_keys.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/misc/dm355evm_keys.c b/drivers/input/misc/dm355evm_keys.c
index b6b7bd4e5462..82e272ebc0ed 100644
--- a/drivers/input/misc/dm355evm_keys.c
+++ b/drivers/input/misc/dm355evm_keys.c
@@ -195,8 +195,6 @@ static int dm355evm_keys_probe(struct platform_device *pdev)
goto fail1;
keys->irq = status;
- input_set_drvdata(input, keys);
-
input->name = "DM355 EVM Controls";
input->phys = "dm355evm/input0";
input->dev.parent = &pdev->dev;
--
2.7.4
next prev parent reply other threads:[~2017-01-23 0:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 0:48 [PATCH 0/5] Input: Drop unnecessary calls to input_set_drvdata Guenter Roeck
2017-01-23 0:48 ` [PATCH 1/5] Input: keyboard - drop " Guenter Roeck
2017-01-23 0:48 ` [PATCH 2/5] Input: joystick/maplecontrol - drop unnecessary call " Guenter Roeck
2017-01-23 0:48 ` [PATCH 3/5] Input: mouse - drop unnecessary calls " Guenter Roeck
2017-01-23 0:48 ` Guenter Roeck [this message]
2017-01-23 0:48 ` [PATCH 5/5] Input: touchscreen " Guenter Roeck
2017-01-23 1:30 ` [PATCH 0/5] Input: Drop " Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485132505-14562-5-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).