From: Jaejoong Kim <climbbb.kim@gmail.com>
To: jikos@kernel.org, benjamin.tissoires@redhat.com
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, Jaejoong Kim <climbbb.kim@gmail.com>
Subject: [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev
Date: Thu, 2 Mar 2017 22:45:29 +0900 [thread overview]
Message-ID: <1488462330-12349-2-git-send-email-climbbb.kim@gmail.com> (raw)
In-Reply-To: <1488462330-12349-1-git-send-email-climbbb.kim@gmail.com>
We need to store the minor number each drivers. In case of hidraw, it's
minor number stores in struct hidraw. But hiddev's minor is located in
struct hid_device.
So reallocates for hiddev's minor number.
Signed-off-by: Jaejoong Kim <climbbb.kim@gmail.com>
---
drivers/hid/usbhid/hiddev.c | 1 +
include/linux/hid.h | 1 -
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 700145b..5c2c489 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -47,6 +47,7 @@
#define HIDDEV_BUFFER_SIZE 2048
struct hiddev {
+ int minor;
int exist;
int open;
struct mutex existancelock;
diff --git a/include/linux/hid.h b/include/linux/hid.h
index 28f38e2b8..643c017 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -541,7 +541,6 @@ struct hid_device { /* device report descriptor */
struct list_head inputs; /* The list of inputs */
void *hiddev; /* The hiddev structure */
void *hidraw;
- int minor; /* Hiddev minor number */
int open; /* is the device open by anyone? */
char name[128]; /* Device name */
--
2.7.4
next prev parent reply other threads:[~2017-03-02 13:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 13:45 [PATCH 0/2] HID: hiddev: move hiddev's minor number and refactoring Jaejoong Kim
2017-03-02 13:45 ` Jaejoong Kim [this message]
2017-03-02 14:10 ` [PATCH 1/2] HID: hiddev: move hiddev's minor number from struct hid_device to hiddev Benjamin Tissoires
2017-03-03 7:00 ` Kim Jaejoong
2017-03-03 14:47 ` kbuild test robot
2017-03-03 15:28 ` kbuild test robot
2017-03-02 13:45 ` [PATCH 2/2] HID: hiddev: store hiddev's minor number when hiddev is connected Jaejoong Kim
[not found] ` <1488462330-12349-3-git-send-email-climbbb.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-03-02 14:13 ` Benjamin Tissoires
2017-03-03 7:05 ` Kim Jaejoong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1488462330-12349-2-git-send-email-climbbb.kim@gmail.com \
--to=climbbb.kim@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).