From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2] Input: silead - Do not try to directly access the GPIO when using ACPI pm Date: Wed, 08 Mar 2017 20:25:25 +0200 Message-ID: <1488997525.20145.161.camel@linux.intel.com> References: <20170122200008.27027-1-hdegoede@redhat.com> <20170202121018.GN2053@lahna.fi.intel.com> <20170202123206.GP2053@lahna.fi.intel.com> <20170202131251.GQ2053@lahna.fi.intel.com> <3f433773-27ba-8d07-3209-6df71d6d4b33@redhat.com> <1487778778.20145.22.camel@linux.intel.com> <65b7a7ed-3199-84d2-c004-adedadce1d88@redhat.com> <1488454727.20145.71.camel@linux.intel.com> <1488553076.20145.79.camel@linux.intel.com> <3be3837a-a57c-e6bf-538b-e135c1b37ff0@redhat.com> <1488554609.20145.81.camel@linux.intel.com> <693ce7b3-99e9-eb60-b164-50b27294a239@redhat.com> <1488887470.20145.108.camel@linux.intel.com> <015d1f87-fcfe-b08d-6934-732145d534ca@redhat.com> <1488969002.20145.119.camel@linux.intel.com> <1488973582.20145.125.camel@linux.intel.com> <654981a1-2493-01d6-13e6-1287b70e22f2@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from mga04.intel.com ([192.55.52.120]:8376 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754150AbdCHWJM (ORCPT ); Wed, 8 Mar 2017 17:09:12 -0500 In-Reply-To: <654981a1-2493-01d6-13e6-1287b70e22f2@redhat.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Hans de Goede , Mika Westerberg , Daniel Vetter Cc: Dmitry Torokhov , "russianneuromancer @ ya . ru" , Gregor Riepl , linux-input@vger.kernel.org, Linus Walleij On Wed, 2017-03-08 at 18:05 +0100, Hans de Goede wrote: > Hi, > > On 08-03-17 12:46, Andy Shevchenko wrote: > > On Wed, 2017-03-08 at 12:27 +0100, Hans de Goede wrote: > > > On 08-03-17 11:30, Andy Shevchenko wrote: > > > > On Wed, 2017-03-08 at 10:08 +0100, Hans de Goede wrote: > > > > > On 07-03-17 14:55, Hans de Goede wrote: > > NULL sounds to me a bit clearer in this case, since the original > > name of > > connection IDs with underscores, not dashes. > > Ok, so pass NULL and then drop the patch to add the mapping table, > because with a NULL con-id that won't be necessary right ? > > I've just given this a spin (patch to pass NULl attached), your > patch to add the GPIO ACPI mapping table dropped and this works well > I agree just passing NULL as con-id is the better solution for > soc_button_array. Yeah. The attached patch you sent is fine by me. > > > > > I think that "extcon: int3496: Add GPIO ACPI mapping table" > > > > > will > > > > > need > > > > > a similar change (I haven't tested it yet). > > So I assume you want to do the same (pass NULL as con-id to > gpiod_get_index()) for the extcon-in3496 driver or do you want > to keep the GPIO ACPI mapping table there? A slightly preferable table variant (needs to be fixed I guess) because initial one used to have different labels. Though if you would like to move to NULL, I wouldn't object. -- Andy Shevchenko Intel Finland Oy