From: Bastien Nocera <hadess@hadess.net>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Jiri Kosina <jikos@kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: Add driver for Retrode2 joypad adapter
Date: Wed, 07 Jun 2017 17:42:53 +0200 [thread overview]
Message-ID: <1496850173.11482.7.camel@hadess.net> (raw)
In-Reply-To: <20170607142858.GF16591@mail.corp.redhat.com>
On Wed, 2017-06-07 at 16:28 +0200, Benjamin Tissoires wrote:
> On Jun 07 2017 or thereabouts, Bastien Nocera wrote:
<snip>
> > + hid_err(hdev, "parse failed\n");
>
> This error message is probably too much, just return in case of
> failure,
> we will get an error if something wrong happens.
>
> > + return ret;
> > + }
> > +
> > + ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
> > + if (ret) {
> > + hid_err(hdev, "hw start failed\n");
>
> Same here.
Both fixed.
> > +static const struct hid_device_id retrode_devices[] = {
> > + { HID_USB_DEVICE(USB_VENDOR_ID_FUTURE_TECHNOLOGY,
> > USB_DEVICE_ID_RETRODE2) },
>
> Aren't you missing the same entry in hid-core.c
> hid_have_special_driver?
I guess I am, fixed.
prev parent reply other threads:[~2017-06-07 15:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-07 14:15 [PATCH] HID: Add driver for Retrode2 joypad adapter Bastien Nocera
2017-06-07 14:28 ` Benjamin Tissoires
2017-06-07 15:42 ` Bastien Nocera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1496850173.11482.7.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).