From: Bastien Nocera <hadess@hadess.net>
To: "Sergei A. Trusov" <sergei.a.trusov@ya.ru>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
russianneuromancer@ya.ru, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: goodix: Add support for capacitive home button found on some x86 tablets
Date: Tue, 20 Jun 2017 11:29:01 +0200 [thread overview]
Message-ID: <1497950941.2559.13.camel@hadess.net> (raw)
In-Reply-To: <1567005.gF9xgO7RRS@z12>
On Tue, 2017-06-20 at 19:26 +1000, Sergei A. Trusov wrote:
>
<snip>
> Thank you for this point. Now I see all the changes above are
> redundant:
> we can use a value returned in the *data buffer. It is enough to add
> only two lines of code to achieve the behaviour of this entire patch.
A bit more with a comment explaining the reason behind those 2 lines,
but shorter patches get my vote ;)
next prev parent reply other threads:[~2017-06-20 9:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-17 9:42 [PATCH] Input: goodix: Add support for capacitive home button found on some x86 tablets Sergei A. Trusov
2017-06-17 19:34 ` Hans de Goede
2017-06-19 22:32 ` Bastien Nocera
2017-06-20 2:51 ` Dmitry Torokhov
2017-06-20 8:36 ` Bastien Nocera
2017-06-20 9:02 ` Hans de Goede
2017-06-20 9:26 ` Sergei A. Trusov
2017-06-20 9:29 ` Bastien Nocera [this message]
2017-06-20 10:11 ` Sergei A. Trusov
2017-06-20 10:20 ` Bastien Nocera
2017-06-20 10:47 ` Sergei A. Trusov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497950941.2559.13.camel@hadess.net \
--to=hadess@hadess.net \
--cc=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=russianneuromancer@ya.ru \
--cc=sergei.a.trusov@ya.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).