From: Bastien Nocera <hadess@hadess.net>
To: Alex Henrie <alexhenrie24@gmail.com>
Cc: Lukas Wunner <lukas@wunner.de>, Jiri Kosina <jikos@kernel.org>,
benjamin.tissoires@redhat.com, jirislaby@gmail.com,
stefan@glasen-hardt.de, ryan@finnie.org,
Johannes Thumshirn <morbidrsa@gmail.com>,
dan@pwienterprises.com, Andreas Krist <andreas.krist@gmail.com>,
rydberg@bitmath.org, John Horan <Knasher@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3] HID: apple: Use country code to detect ISO keyboards
Date: Tue, 20 Jun 2017 20:00:53 +0200 [thread overview]
Message-ID: <1497981653.2559.28.camel@hadess.net> (raw)
In-Reply-To: <CAMMLpeQ2PaP3hySi-wukzkxdk=fSvGyOsPqTPZmof=U5s9=8Vg@mail.gmail.com>
On Tue, 2017-06-20 at 11:18 -0600, Alex Henrie wrote:
>
<snip>
> > Does this patch mean we can assume that the hardware model is
> > "pc105"
> > instead of various flavours of "mac" in xkeyboard-config's X
> > keymaps?
>
> I use the pc105 keymap with my Macbook 12,1 and don't have any
> problems, so for me at least, the answer is yes.
Yay! This was a long-standing "wouldn't it be nice" bug from when I
still used a MacBook Air on a daily basis:
https://bugzilla.gnome.org/show_bug.cgi?id=650379
https://bugzilla.gnome.org/show_bug.cgi?id=650772
https://bugs.freedesktop.org/show_bug.cgi?id=37446
> > Does this also work with older Apple USB keyboards? (Most of the
> > older
> > ones triggered the "press those 2 buttons so we can figure out
> > which
> > type of keyboard you have", under macOS)
>
> The oldest Apple ISO keyboard I could find information on is the
> "Apple Geyser3 ISO", USB ID 05ac:0218. In 2008 an Arch Linux forum
> user posted the output of `lsusb -v` which shows that bCountryCode is
> set to 13 on this keyboard:
> https://bbs.archlinux.org/viewtopic.php?pid=328653#p328653
>
> Do you have any old Apple ISO keyboards? If you find one that doesn't
> fill in bCountryCode, we could bring back the APPLE_ISO_KEYBOARD
> quirk
> for that model.
I have a 2011 MacBook Pro on which I could test this (I honestly don't
remember the cut-off for ADB/BIOS keyboards to USB), but no external
ones.
I also wonder whether that data is exported for Bluetooth and the newer
I2C keyboards.
next prev parent reply other threads:[~2017-06-20 18:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:28 [PATCH v3] HID: apple: Use country code to detect ISO keyboards Alex Henrie
2017-06-06 7:29 ` Benjamin Tissoires
2017-06-08 12:03 ` Jiri Kosina
2017-06-08 15:15 ` Alex Henrie
2017-06-17 18:56 ` Lukas Wunner
2017-06-20 11:54 ` Bastien Nocera
2017-06-20 17:18 ` Alex Henrie
2017-06-20 18:00 ` Bastien Nocera [this message]
2017-08-05 17:09 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497981653.2559.28.camel@hadess.net \
--to=hadess@hadess.net \
--cc=Knasher@gmail.com \
--cc=alexhenrie24@gmail.com \
--cc=andreas.krist@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dan@pwienterprises.com \
--cc=jikos@kernel.org \
--cc=jirislaby@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=morbidrsa@gmail.com \
--cc=ryan@finnie.org \
--cc=rydberg@bitmath.org \
--cc=stefan@glasen-hardt.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).