* [PATCH 3/4] HID: logitech-hidpp: constify attribute_group structures.
@ 2017-08-03 11:29 Arvind Yadav
2017-08-03 11:29 ` [PATCH 4/4] HID: ntrig: " Arvind Yadav
0 siblings, 1 reply; 2+ messages in thread
From: Arvind Yadav @ 2017-08-03 11:29 UTC (permalink / raw)
To: jikos, benjamin.tissoires; +Cc: linux-kernel, linux-input
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/hid/hid-logitech-hidpp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 41b3946..fc8de14 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/hid/hid-logitech-hidpp.c
@@ -2923,7 +2923,7 @@ static void hidpp_connect_event(struct hidpp_device *hidpp)
NULL
};
-static struct attribute_group ps_attribute_group = {
+static const struct attribute_group ps_attribute_group = {
.attrs = sysfs_attrs
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 4/4] HID: ntrig: constify attribute_group structures.
2017-08-03 11:29 [PATCH 3/4] HID: logitech-hidpp: constify attribute_group structures Arvind Yadav
@ 2017-08-03 11:29 ` Arvind Yadav
0 siblings, 0 replies; 2+ messages in thread
From: Arvind Yadav @ 2017-08-03 11:29 UTC (permalink / raw)
To: jikos, benjamin.tissoires; +Cc: linux-kernel, linux-input
attribute_group are not supposed to change at runtime. All functions
working with attribute_group provided by <linux/sysfs.h> work with
const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/hid/hid-ntrig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
index 1b0084d..3d121d8 100644
--- a/drivers/hid/hid-ntrig.c
+++ b/drivers/hid/hid-ntrig.c
@@ -445,7 +445,7 @@ static DEVICE_ATTR(deactivate_slack, S_IWUSR | S_IRUGO, show_deactivate_slack,
NULL
};
-static struct attribute_group ntrig_attribute_group = {
+static const struct attribute_group ntrig_attribute_group = {
.attrs = sysfs_attrs
};
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-03 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-03 11:29 [PATCH 3/4] HID: logitech-hidpp: constify attribute_group structures Arvind Yadav
2017-08-03 11:29 ` [PATCH 4/4] HID: ntrig: " Arvind Yadav
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).