From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Johannes Stezenbach <js@sig21.net>,
linux-input@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button
Date: Fri, 01 Sep 2017 14:09:36 +0300 [thread overview]
Message-ID: <1504264176.25945.190.camel@linux.intel.com> (raw)
In-Reply-To: <20170831183355.GB14370@dtor-ws>
On Thu, 2017-08-31 at 11:33 -0700, Dmitry Torokhov wrote:
> > +
> > + ret = enable_irq_wake(irq);
> > + if (ret)
> > + dev_warn(dev, "Can't enable IRQ as wake source:
> > %d\n", ret);
>
> We do not normally enable wake IRQs in probe, but instead do:
>
> device_init_wakeup(&pdev->dev, true);
>
> in probe() and then check it in suspend/resume:
>
> if (device_may_wakeup(dev)) {
> err = enable_irq_wake(XXX->irq);
> if (!err)
> XXX->irq_wake_enabled = true;
> }
>
> ...
>
> if (XXX->irq_wake_enabled)
No need to duplicate a flag which IRQ core already has.
See, for example, commit
aef3ad103a68 ("serial: core: remove unneeded irq_wake flag")
> disable_irq_wake(XXX->irq);
>
> This allows userspace to inhibit wakeup, if needed.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-09-01 11:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-22 5:57 [PATCH 0/3] Dollar Cove TI PMIC support for Intel Cherry Trail Takashi Iwai
2017-08-22 5:57 ` [PATCH 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC Takashi Iwai
2017-08-22 9:37 ` Andy Shevchenko
2017-08-22 10:27 ` Takashi Iwai
2017-08-22 5:57 ` [PATCH 2/3] input/keyboard: Add support for Dollar Cove TI power button Takashi Iwai
2017-08-22 9:42 ` Andy Shevchenko
2017-08-22 10:58 ` Takashi Iwai
2017-08-22 17:25 ` Johannes Stezenbach
2017-08-31 18:33 ` Dmitry Torokhov
2017-08-31 20:34 ` Takashi Iwai
2017-09-01 11:09 ` Andy Shevchenko [this message]
2017-09-01 12:12 ` Takashi Iwai
2017-08-22 5:57 ` [PATCH 3/3] ACPI / PMIC: Add opregion driver for Intel Dollar Cove TI PMIC Takashi Iwai
2017-08-22 9:58 ` Andy Shevchenko
2017-08-22 10:25 ` Takashi Iwai
2017-08-22 11:01 ` Takashi Iwai
2017-08-22 11:37 ` Andy Shevchenko
2017-08-22 12:06 ` Takashi Iwai
2017-08-22 12:08 ` Andy Shevchenko
2017-08-22 12:26 ` Takashi Iwai
2017-08-22 13:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504264176.25945.190.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=js@sig21.net \
--cc=lee.jones@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).