Linux Input/HID development
 help / color / mirror / Atom feed
From: nolsen@jabra.com
To: linux-input@vger.kernel.org
Cc: jikos@kernel.org, benjamin.tissoires@redhat.com,
	dmitry.torokhov@gmail.com, Niels Skou Olsen <nolsen@jabra.com>
Subject: [PATCH] HID: Remove Jabra speakerphone devices from ignore list
Date: Tue,  5 Sep 2017 14:23:16 +0200	[thread overview]
Message-ID: <1504614196-25107-1-git-send-email-nolsen@jabra.com> (raw)

From: Niels Skou Olsen <nolsen@jabra.com>

Two Jabra speakerphone devices were added to the ignore list in 2013
because, at the time, the device HID interfaces didn't work well with
kernel usbhid driver, and could reportedly cause volume key event
storm.

See the original commit:
Commit 31b9779cb292 ("HID: ignore Jabra speakerphones HID interface")

Testing the devices today reveals no such problems, and the
blacklisting can safely be removed.

Signed-off-by: Niels Skou Olsen <nolsen@jabra.com>
---
 drivers/hid/hid-core.c | 2 --
 drivers/hid/hid-ids.h  | 2 --
 2 files changed, 4 deletions(-)

diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 9bc9116..b49d7c4 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -2697,8 +2697,6 @@ static const struct hid_device_id hid_ignore_list[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_1006) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_1007) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_IMATION, USB_DEVICE_ID_DISC_STAKKA) },
-	{ HID_USB_DEVICE(USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_SPEAK_410) },
-	{ HID_USB_DEVICE(USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_SPEAK_510) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_JABRA, USB_DEVICE_ID_JABRA_GN9350E) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KBGEAR, USB_DEVICE_ID_KBGEAR_JAMSTUDIO) },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_KWORLD, USB_DEVICE_ID_KWORLD_RADIO_FM700) },
diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index b397a14..12b9179 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -578,8 +578,6 @@
 #define USB_DEVICE_ID_ITE8595		0x8595
 
 #define USB_VENDOR_ID_JABRA		0x0b0e
-#define USB_DEVICE_ID_JABRA_SPEAK_410	0x0412
-#define USB_DEVICE_ID_JABRA_SPEAK_510	0x0420
 #define USB_DEVICE_ID_JABRA_GN9350E	0x9350
 
 #define USB_VENDOR_ID_JESS		0x0c45
-- 
2.7.4


             reply	other threads:[~2017-09-05 12:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 12:23 nolsen [this message]
2017-09-08 13:13 ` [PATCH] HID: Remove Jabra speakerphone devices from ignore list Jiri Kosina
  -- strict thread matches above, loose matches on Subject: below --
2017-09-08 14:43 Vincent Palatin
2017-09-11  9:27 ` Niels Skou Olsen
2017-09-12 10:04   ` Vincent Palatin
2017-09-12 14:22     ` Niels Skou Olsen
2017-09-13 13:33       ` Vincent Palatin
2017-09-13 17:02         ` benjamin.tissoires
2017-09-13 17:11           ` Jiri Kosina
2017-09-15  7:52             ` Niels Skou Olsen
2017-09-15  8:08               ` Vincent Palatin
2017-09-18 13:21             ` Niels Skou Olsen
2017-09-14 16:11           ` Richard Hughes
2017-09-15  7:56             ` Niels Skou Olsen
2017-09-15  7:34           ` Niels Skou Olsen
2017-09-15  7:20         ` Niels Skou Olsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1504614196-25107-1-git-send-email-nolsen@jabra.com \
    --to=nolsen@jabra.com \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox