From: Bastien Nocera <hadess@hadess.net>
To: linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jiri Kosina <jikos@kernel.org>,
"Sergei A. Trusov" <sergei.a.trusov@ya.ru>
Subject: Re: [PATCH v3] Input: goodix: Add support for capacitive home button
Date: Wed, 06 Sep 2017 11:00:19 +0200 [thread overview]
Message-ID: <1504688419.6911.55.camel@hadess.net> (raw)
In-Reply-To: <20170620160835.13904-1-hadess@hadess.net>
Hey,
On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote:
> From: "Sergei A. Trusov" <sergei.a.trusov@ya.ru>
>
> On some x86 tablets with a Goodix touchscreen, the Windows logo on
> the
> front is a capacitive home button. Touching this button results in a
> touch
> with bit 4 of the first byte set, while only the lower 4 bits (0-3)
> are
> used to indicate the number of touches.
>
> Report a KEY_LEFTMETA press when this happens.
>
> Note that the hardware might support more than one button, in which
> case the "id" byte of coor_data would identify the button in
> question.
> This is not implemented as we don't have access to hardware with
> multiple buttons.
>
> Signed-off-by: Sergei A. Trusov <sergei.a.trusov@ya.ru>
> Acked-by: Bastien Nocera <hadess@hadess.net>
Can we please get this merged? I didn't receive any reviews on it, and
it's been sitting there for 2 months...
next prev parent reply other threads:[~2017-09-06 9:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 16:08 [PATCH v3] Input: goodix: Add support for capacitive home button Bastien Nocera
2017-09-06 9:00 ` Bastien Nocera [this message]
2017-09-06 9:03 ` Jiri Kosina
2017-09-07 0:30 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504688419.6911.55.camel@hadess.net \
--to=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.a.trusov@ya.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).