From: Oliver Neukum <oneukum@suse.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jikos@kernel.org>
Cc: Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup
Date: Sat, 09 Sep 2017 09:35:52 +0200 [thread overview]
Message-ID: <1504942552.10395.2.camel@suse.com> (raw)
In-Reply-To: <20170908174337.GA13616@dtor-ws>
Am Freitag, den 08.09.2017, 10:43 -0700 schrieb Dmitry Torokhov:
> From: Benson Leung <bleung@chromium.org>
>
> usbhid->intf->needs_remote_wakeup is set when a device is opened, and is
> cleared when a device is closed.
>
> In usbhid_open, usb_autopm_get_interface is called before setting the
> needs_remote_wakeup flag, and usb_autopm_put_interface is called after
> hid_start_in. However, when the device is closed in usbhid_close, we
> simply reset the flag and the device stays awake even though it could be
> suspended.
Hi,
but if the device is asleep, we do not want to wake it just to reset
the flag. Please use the no resume varieties. They did not exist when this
code was written and that is the reason behind the current code.
As it is your patch does more harm than good.
Regards
Oliver
next prev parent reply other threads:[~2017-09-09 7:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 17:43 [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup Dmitry Torokhov
2017-09-09 7:35 ` Oliver Neukum [this message]
[not found] ` <1504942552.10395.2.camel-IBi9RG/b67k@public.gmane.org>
2017-09-11 20:02 ` Benson Leung
2017-09-11 23:29 ` Benson Leung
2017-09-20 1:39 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2014-11-13 20:16 Benson Leung
2014-11-13 20:41 ` Alan Stern
2014-11-13 20:44 ` Benson Leung
[not found] ` <CANLzEksGg0KyWOS+WYv_U8GzSJ4C_H0LTpdXvz8Ae-8mH6K41w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-13 21:18 ` Alan Stern
2014-11-13 21:41 ` Benson Leung
2014-11-13 22:11 ` Alan Stern
2014-11-13 22:15 ` Benson Leung
[not found] ` <CANLzEksHgo_tQiwJoUtXd0iV7tDXq0ieNrAXgtXwPtxxPBWrgw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-14 15:17 ` Alan Stern
2014-11-22 0:44 ` Benson Leung
2014-11-22 15:55 ` Alan Stern
2014-11-22 16:02 ` Alan Stern
2014-11-25 1:29 ` Benson Leung
2014-11-25 15:24 ` Alan Stern
2014-11-25 15:29 ` Benson Leung
2014-11-14 9:08 ` Oliver Neukum
2014-11-22 1:00 ` Benson Leung
2014-11-24 9:13 ` Oliver Neukum
[not found] ` <1416820395.19925.4.camel-AfvqVibwNMkMNNZnWhT/Jw@public.gmane.org>
2014-11-25 0:56 ` Benson Leung
2014-11-25 9:53 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504942552.10395.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bleung@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).