From: Simon Budig <simon.budig@kernelconcepts.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH 1/3] edt-ft5x06: fix reset pin behaviour
Date: Tue, 10 Oct 2017 12:39:12 +0200 [thread overview]
Message-ID: <1507631952.5466.20.camel@kernelconcepts.de> (raw)
In-Reply-To: <1507631156.5466.14.camel@kernelconcepts.de>
[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]
On Tue, 2017-10-10 at 12:25 +0200, Simon Budig wrote:
> *If* that is actually the case (i.e. requesting an pin specified as
> GPIO_ACTIVE_LOW in the devicetree with the GPIOD_OUT_HIGH flag
> results in 0V on this pin) then this patch should probably be
> dropped, although I don't like how this code reads then.
Ok, I've traced the code in the gpio-subsystem and indeed, requesting
with the GPIOD_OUT_HIGH flag results in a LOW leveGPIOD_OUT_HIGH upon
request when the GPIO_ACTIVE_LOW is set on that pin.
That constant really should've been called GPIOD_OUT_ACTIVE or
something. That reads confusing as heck.
Anyway, please drop this patch. It doesn't actually do any good.
Thanks,
Simon
--
kernel concepts GmbH Simon Budig
Sieghuetter Hauptweg 48 simon.budig@kernelconcepts.de
D-57072 Siegen +49-271-771091-17
http://www.kernelconcepts.de/
HR Siegen, HR B 9613; Geschäftsführer: Ole Reinhardt
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2017-10-10 10:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 15:31 [Patch 0/3] Some updates to the edt-ft5x06 driver Simon Budig
2017-10-05 15:35 ` [PATCH 1/3] edt-ft5x06: fix reset pin behaviour simon.budig
2017-10-05 15:35 ` [PATCH 2/3] input: edt-ft5x06: make distinction between m06/m09/generic more clear simon.budig
2017-10-05 15:35 ` [PATCH 3/3] input: edt-ft5x06: implement support for the EDT-M12 series simon.budig
2017-10-10 3:58 ` [PATCH 1/3] edt-ft5x06: fix reset pin behaviour Dmitry Torokhov
2017-10-10 10:25 ` Simon Budig
2017-10-10 10:39 ` Simon Budig [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-10-05 15:19 simon.budig
2017-10-05 15:22 ` Simon Budig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507631952.5466.20.camel@kernelconcepts.de \
--to=simon.budig@kernelconcepts.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).