From: Lin Huang <hl@rock-chips.com>
To: dmitry.torokhov@gmail.com, jikos@kernel.org
Cc: benjamin.tissoires@redhat.com, jani.nikula@intel.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
briannorris@chromium.org, Lin Huang <hl@rock-chips.com>
Subject: [PATCH] HID: i2c-hid: add reset gpio property
Date: Mon, 30 Oct 2017 10:49:49 +0800 [thread overview]
Message-ID: <1509331789-1949-1-git-send-email-hl@rock-chips.com> (raw)
some i2c hid devices have reset gpio, need to control
it in the driver.
Change-Id: I87bca954bffc7eb7b35711406f522cb3d0fc2ded
Signed-off-by: Lin Huang <hl@rock-chips.com>
---
drivers/hid/i2c-hid/i2c-hid.c | 63 +++++++++++++++++++++++++++--------
include/linux/platform_data/i2c-hid.h | 4 +++
2 files changed, 53 insertions(+), 14 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
index 9145c21..a0e3a8e 100644
--- a/drivers/hid/i2c-hid/i2c-hid.c
+++ b/drivers/hid/i2c-hid/i2c-hid.c
@@ -38,6 +38,7 @@
#include <linux/mutex.h>
#include <linux/acpi.h>
#include <linux/of.h>
+#include <linux/gpio/consumer.h>
#include <linux/regulator/consumer.h>
#include <linux/platform_data/i2c-hid.h>
@@ -793,6 +794,34 @@ struct hid_ll_driver i2c_hid_ll_driver = {
};
EXPORT_SYMBOL_GPL(i2c_hid_ll_driver);
+static int i2c_hid_hw_power_on(struct i2c_hid *ihid)
+{
+ int ret;
+
+ ret = regulator_enable(ihid->pdata.supply);
+ if (ret < 0)
+ return ret;
+
+ if (ihid->pdata.post_power_delay_ms)
+ msleep(ihid->pdata.post_power_delay_ms);
+
+ gpiod_set_value_cansleep(ihid->pdata.reset_gpio, 1);
+ usleep_range(ihid->pdata.assert_reset_us,
+ ihid->pdata.assert_reset_us);
+ gpiod_set_value_cansleep(ihid->pdata.reset_gpio, 0);
+ usleep_range(ihid->pdata.deassert_reset_us,
+ ihid->pdata.deassert_reset_us);
+
+ return ret;
+}
+
+static int i2c_hid_hw_power_off(struct i2c_hid *ihid)
+{
+ gpiod_set_value_cansleep(ihid->pdata.reset_gpio, 1);
+
+ return regulator_disable(ihid->pdata.supply);
+}
+
static int i2c_hid_init_irq(struct i2c_client *client)
{
struct i2c_hid *ihid = i2c_get_clientdata(client);
@@ -934,6 +963,12 @@ static int i2c_hid_of_probe(struct i2c_client *client,
if (!ret)
pdata->post_power_delay_ms = val;
+ ret = of_property_read_u32(dev->of_node, "assert-reset-us",
+ &pdata->assert_reset_us);
+
+ ret = of_property_read_u32(dev->of_node, "deassert-reset-us",
+ &pdata->deassert_reset_us);
+
return 0;
}
@@ -1002,14 +1037,16 @@ static int i2c_hid_probe(struct i2c_client *client,
goto err;
}
- ret = regulator_enable(ihid->pdata.supply);
+ ihid->pdata.reset_gpio = devm_gpiod_get_optional(&client->dev, "reset",
+ GPIOD_OUT_HIGH);
+ if (IS_ERR(ihid->pdata.reset_gpio))
+ goto err;
+
+ ret = i2c_hid_hw_power_on(ihid);
if (ret < 0) {
- dev_err(&client->dev, "Failed to enable regulator: %d\n",
- ret);
+ dev_err(&client->dev, "Failed to power on: %d\n", ret);
goto err;
}
- if (ihid->pdata.post_power_delay_ms)
- msleep(ihid->pdata.post_power_delay_ms);
i2c_set_clientdata(client, ihid);
@@ -1086,7 +1123,7 @@ static int i2c_hid_probe(struct i2c_client *client,
pm_runtime_disable(&client->dev);
err_regulator:
- regulator_disable(ihid->pdata.supply);
+ i2c_hid_hw_power_off(ihid);
err:
i2c_hid_free_buffers(ihid);
@@ -1112,8 +1149,7 @@ static int i2c_hid_remove(struct i2c_client *client)
if (ihid->bufsize)
i2c_hid_free_buffers(ihid);
- regulator_disable(ihid->pdata.supply);
-
+ i2c_hid_hw_power_off(ihid);
kfree(ihid);
return 0;
@@ -1165,9 +1201,10 @@ static int i2c_hid_suspend(struct device *dev)
hid_warn(hid, "Failed to enable irq wake: %d\n",
wake_status);
} else {
- ret = regulator_disable(ihid->pdata.supply);
+ ret = i2c_hid_hw_power_off(ihid);
if (ret < 0)
- hid_warn(hid, "Failed to disable supply: %d\n", ret);
+ hid_warn(hid, "Failed to disable hw power: %d\n",
+ ret);
}
return 0;
@@ -1182,11 +1219,9 @@ static int i2c_hid_resume(struct device *dev)
int wake_status;
if (!device_may_wakeup(&client->dev)) {
- ret = regulator_enable(ihid->pdata.supply);
+ ret = i2c_hid_hw_power_on(ihid);
if (ret < 0)
- hid_warn(hid, "Failed to enable supply: %d\n", ret);
- if (ihid->pdata.post_power_delay_ms)
- msleep(ihid->pdata.post_power_delay_ms);
+ hid_warn(hid, "Failed to enable hw power: %d\n", ret);
} else if (ihid->irq_wake_enabled) {
wake_status = disable_irq_wake(client->irq);
if (!wake_status)
diff --git a/include/linux/platform_data/i2c-hid.h b/include/linux/platform_data/i2c-hid.h
index 1fb0882..3afc781 100644
--- a/include/linux/platform_data/i2c-hid.h
+++ b/include/linux/platform_data/i2c-hid.h
@@ -14,6 +14,7 @@
#include <linux/types.h>
+struct gpio_desc;
struct regulator;
/**
@@ -37,6 +38,9 @@ struct i2c_hid_platform_data {
u16 hid_descriptor_address;
struct regulator *supply;
int post_power_delay_ms;
+ struct gpio_desc *reset_gpio;
+ int assert_reset_us;
+ int deassert_reset_us;
};
#endif /* __LINUX_I2C_HID_H */
--
2.7.4
next reply other threads:[~2017-10-30 2:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-30 2:49 Lin Huang [this message]
[not found] ` <1509331789-1949-1-git-send-email-hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2017-10-30 16:57 ` [PATCH] HID: i2c-hid: add reset gpio property Brian Norris
[not found] ` <20171030165753.GA10752-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2017-10-30 20:15 ` Rob Herring
[not found] ` <CAL_JsqKQw7UubSRALsPMUw7rR16xwcSWUzN5wEAqckN7D61Kkg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-10-30 21:16 ` Brian Norris
2017-11-06 9:30 ` Benjamin Tissoires
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1509331789-1949-1-git-send-email-hl@rock-chips.com \
--to=hl@rock-chips.com \
--cc=benjamin.tissoires@redhat.com \
--cc=briannorris@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jani.nikula@intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).