Re: [PATCH v2 3/3] Input: goodix - use generic touchscreen_properties

[Bastien Nocera <hadess@hadess.net>]

On Tue, 2017-11-14 at 10:03 -0800, Dmitry Torokhov wrote:
> On Tue, Nov 14, 2017 at 03:37:09PM +0100, Bastien Nocera wrote:
> > On Tue, 2017-11-14 at 13:42 +0100, Marcin Niestroj wrote:
> > > Use touchscreen_properties structure instead of implementing all
> > > properties by our own. It allows to reuse generic code for
> > > parsing
> > 
> > "It allows reusing"
> > or
> > "It allows us to reuse".
> > 
> > > device-tree properties (which was implemented manually in the
> > > driver
> > > for now). Additionally, it allows us to report events using
> > > generic
> > > touchscreen_report_pos(), which automatically handles inverted
> > > and
> > > swapped axes.
> > 
> > Looks good otherwise. Yay for code removal.
> 
> I am sorry, but I am confused as to why we had to go through all this
> pain fixing the custom code in the driver and then replacing it all
> with
> touchscreen helpers?
> 
> If generic code is shorter and also fixed the bug I do not see the
> reason for intermediate steps...

Patch 2 and 3 can probably be melded. I'm guessing that an intermediate
 change makes it more obvious what the fixes are, and could help with
backporting. Up to you.