* [PATCH] xen/input: do not advertise multi-touch pressure support
@ 2018-01-02 8:12 Oleksandr Andrushchenko
2018-01-02 17:39 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Oleksandr Andrushchenko @ 2018-01-02 8:12 UTC (permalink / raw)
To: xen-devel, linux-kernel, linux-input, dmitry.torokhov
Cc: andr2000, Oleksandr Andrushchenko, Andrii Chepurnyi
From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Some user-space applications expect multi-touch pressure
on contact to be reported if it is advertised in device
properties. Otherwise, such applications may treat reports
not as actual touches, but hovering. Currently this is
only advertised, but not reported.
Fix this by not advertising that ABS_MT_PRESSURE is supported.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Andrii Chepurnyi <andrii_chepurnyi@epam.com>
---
drivers/input/misc/xen-kbdfront.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
index 6bf56bb5f8d9..d91f3b1c5375 100644
--- a/drivers/input/misc/xen-kbdfront.c
+++ b/drivers/input/misc/xen-kbdfront.c
@@ -326,8 +326,6 @@ static int xenkbd_probe(struct xenbus_device *dev,
0, width, 0, 0);
input_set_abs_params(mtouch, ABS_MT_POSITION_Y,
0, height, 0, 0);
- input_set_abs_params(mtouch, ABS_MT_PRESSURE,
- 0, 255, 0, 0);
ret = input_mt_init_slots(mtouch, num_cont, INPUT_MT_DIRECT);
if (ret) {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] xen/input: do not advertise multi-touch pressure support
2018-01-02 8:12 [PATCH] xen/input: do not advertise multi-touch pressure support Oleksandr Andrushchenko
@ 2018-01-02 17:39 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2018-01-02 17:39 UTC (permalink / raw)
To: Oleksandr Andrushchenko
Cc: xen-devel, linux-kernel, linux-input, Oleksandr Andrushchenko,
Andrii Chepurnyi
On Tue, Jan 02, 2018 at 10:12:55AM +0200, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>
> Some user-space applications expect multi-touch pressure
> on contact to be reported if it is advertised in device
> properties. Otherwise, such applications may treat reports
> not as actual touches, but hovering. Currently this is
> only advertised, but not reported.
> Fix this by not advertising that ABS_MT_PRESSURE is supported.
>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> Signed-off-by: Andrii Chepurnyi <andrii_chepurnyi@epam.com>
Applied, thank you.
> ---
> drivers/input/misc/xen-kbdfront.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
> index 6bf56bb5f8d9..d91f3b1c5375 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -326,8 +326,6 @@ static int xenkbd_probe(struct xenbus_device *dev,
> 0, width, 0, 0);
> input_set_abs_params(mtouch, ABS_MT_POSITION_Y,
> 0, height, 0, 0);
> - input_set_abs_params(mtouch, ABS_MT_PRESSURE,
> - 0, 255, 0, 0);
>
> ret = input_mt_init_slots(mtouch, num_cont, INPUT_MT_DIRECT);
> if (ret) {
> --
> 2.7.4
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-02 17:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02 8:12 [PATCH] xen/input: do not advertise multi-touch pressure support Oleksandr Andrushchenko
2018-01-02 17:39 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).