* [PATCH] HID: hid-ntrig: add error handling for sysfs_create_group
@ 2018-06-11 8:54 Zhouyang Jia
2018-06-11 12:20 ` Jiri Kosina
2018-06-14 13:37 ` [PATCH v2] " Zhouyang Jia
0 siblings, 2 replies; 4+ messages in thread
From: Zhouyang Jia @ 2018-06-11 8:54 UTC (permalink / raw)
Cc: Zhouyang Jia, Jiri Kosina, Benjamin Tissoires, linux-input,
linux-kernel
When sysfs_create_group fails, the lack of error-handling code may
cause unexpected results.
This patch adds error-handling code after calling sysfs_create_group.
Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
---
drivers/hid/hid-ntrig.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
index 43b1c72..1e70dae 100644
--- a/drivers/hid/hid-ntrig.c
+++ b/drivers/hid/hid-ntrig.c
@@ -955,6 +955,10 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)
ret = sysfs_create_group(&hdev->dev.kobj,
&ntrig_attribute_group);
+ if (ret) {
+ hid_err(hdev, "cannot create sysfs group\n");
+ goto err_free;
+ }
return 0;
err_free:
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] HID: hid-ntrig: add error handling for sysfs_create_group
2018-06-11 8:54 [PATCH] HID: hid-ntrig: add error handling for sysfs_create_group Zhouyang Jia
@ 2018-06-11 12:20 ` Jiri Kosina
2018-06-14 13:37 ` [PATCH v2] " Zhouyang Jia
1 sibling, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2018-06-11 12:20 UTC (permalink / raw)
To: Zhouyang Jia; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Mon, 11 Jun 2018, Zhouyang Jia wrote:
> When sysfs_create_group fails, the lack of error-handling code may
> cause unexpected results.
>
> This patch adds error-handling code after calling sysfs_create_group.
>
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
> ---
> drivers/hid/hid-ntrig.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
> index 43b1c72..1e70dae 100644
> --- a/drivers/hid/hid-ntrig.c
> +++ b/drivers/hid/hid-ntrig.c
> @@ -955,6 +955,10 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)
>
> ret = sysfs_create_group(&hdev->dev.kobj,
> &ntrig_attribute_group);
> + if (ret) {
> + hid_err(hdev, "cannot create sysfs group\n");
> + goto err_free;
> + }
Is it really necessarily to bail out completely here and render the device
dysfunctional? Issuing a warning about sysfs knobs being unavailable might
be more appropriate.
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] HID: hid-ntrig: add error handling for sysfs_create_group
2018-06-11 8:54 [PATCH] HID: hid-ntrig: add error handling for sysfs_create_group Zhouyang Jia
2018-06-11 12:20 ` Jiri Kosina
@ 2018-06-14 13:37 ` Zhouyang Jia
2018-06-25 13:16 ` Jiri Kosina
1 sibling, 1 reply; 4+ messages in thread
From: Zhouyang Jia @ 2018-06-14 13:37 UTC (permalink / raw)
Cc: Zhouyang Jia, Jiri Kosina, Benjamin Tissoires, linux-input,
linux-kernel
When sysfs_create_group fails, the lack of error-handling code may
cause unexpected results.
This patch adds error-handling code after calling sysfs_create_group.
Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
---
v1->v2:
- Remove goto statement.
---
drivers/hid/hid-ntrig.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-ntrig.c b/drivers/hid/hid-ntrig.c
index 43b1c72..9bc6f48 100644
--- a/drivers/hid/hid-ntrig.c
+++ b/drivers/hid/hid-ntrig.c
@@ -955,6 +955,8 @@ static int ntrig_probe(struct hid_device *hdev, const struct hid_device_id *id)
ret = sysfs_create_group(&hdev->dev.kobj,
&ntrig_attribute_group);
+ if (ret)
+ hid_err(hdev, "cannot create sysfs group\n");
return 0;
err_free:
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] HID: hid-ntrig: add error handling for sysfs_create_group
2018-06-14 13:37 ` [PATCH v2] " Zhouyang Jia
@ 2018-06-25 13:16 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2018-06-25 13:16 UTC (permalink / raw)
To: Zhouyang Jia; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Thu, 14 Jun 2018, Zhouyang Jia wrote:
> When sysfs_create_group fails, the lack of error-handling code may
> cause unexpected results.
>
> This patch adds error-handling code after calling sysfs_create_group.
>
> Signed-off-by: Zhouyang Jia <jiazhouyang09@gmail.com>
> ---
> v1->v2:
> - Remove goto statement.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-25 13:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-11 8:54 [PATCH] HID: hid-ntrig: add error handling for sysfs_create_group Zhouyang Jia
2018-06-11 12:20 ` Jiri Kosina
2018-06-14 13:37 ` [PATCH v2] " Zhouyang Jia
2018-06-25 13:16 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).