From: Michael Schmitz <schmitzmic@gmail.com>
To: linux-input@vger.kernel.org
Cc: debian-68k@lists.debian.org, linux-m68k@lists.linux-m68k.org
Subject: [PATCH 0/2] input: atakbd.c bug fixes
Date: Fri, 7 Sep 2018 11:40:41 +1200 [thread overview]
Message-ID: <1536277243-3821-1-git-send-email-schmitzmic@gmail.com> (raw)
Two bug fixes for the Atari keyboard input driver:
- keymap fixes: multiple keymap errors that had gone unnoticed
since migration of the m68k keyboard driver code to the
input framework. Correct the wrong keycodes - keymap is stil
US but keypad, help and undo keys all generate the correct keycodes now.
- capslock fix: the Atari driver incorrectly assumed that capslock
were a toggle key (i.e. sending no break scancodes), and synthesized
a make/break keycode pair on each capslock scancode. This resulted in
duplicate make/break codes on key release, and capslock functioning as
a shift key. Remove code sending make/break pairs to get functional
capslock behaviour.
Tested on my own Atari Falcon 030.
TIA for your review. Please CC linux-m68k in replies.
Cheers,
Michael
CC to debian-68k, for consideration at the upcoming m68k hackers meeting.
next reply other threads:[~2018-09-06 23:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 23:40 Michael Schmitz [this message]
2018-09-06 23:40 ` [PATCH 1/2] input: atakbd.c - fix Atari keymap Michael Schmitz
2018-09-07 0:26 ` Finn Thain
2018-09-07 9:22 ` Andreas Schwab
2018-09-08 8:06 ` Michael Schmitz
2018-09-06 23:40 ` [PATCH 2/2] input: atakbd.c - fix Atari CapsLock behaviour Michael Schmitz
2018-09-17 19:43 ` Dmitry Torokhov
2018-09-17 20:29 ` Andreas Schwab
2018-09-17 22:36 ` Dmitry Torokhov
2018-09-18 2:03 ` Michael Schmitz
2018-09-18 17:08 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536277243-3821-1-git-send-email-schmitzmic@gmail.com \
--to=schmitzmic@gmail.com \
--cc=debian-68k@lists.debian.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).