* [PATCH] HID: roccat: Mark expected switch fall-through
@ 2018-07-02 18:29 Gustavo A. R. Silva
2018-07-17 13:53 ` Jiri Kosina
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2018-07-02 18:29 UTC (permalink / raw)
To: Stefan Achatz, Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/hid/hid-roccat-kone.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
index bf4675a..c4dd616 100644
--- a/drivers/hid/hid-roccat-kone.c
+++ b/drivers/hid/hid-roccat-kone.c
@@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct kone_device *kone,
case kone_mouse_event_switch_profile:
kone->actual_dpi = kone->profiles[event->value - 1].
startup_dpi;
+ /* fall through */
case kone_mouse_event_osd_profile:
kone->actual_profile = event->value;
break;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: roccat: Mark expected switch fall-through
2018-07-02 18:29 Gustavo A. R. Silva
@ 2018-07-17 13:53 ` Jiri Kosina
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2018-07-17 13:53 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Stefan Achatz, Benjamin Tissoires, linux-input, linux-kernel
On Mon, 2 Jul 2018, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/hid/hid-roccat-kone.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
> index bf4675a..c4dd616 100644
> --- a/drivers/hid/hid-roccat-kone.c
> +++ b/drivers/hid/hid-roccat-kone.c
> @@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct kone_device *kone,
> case kone_mouse_event_switch_profile:
> kone->actual_dpi = kone->profiles[event->value - 1].
> startup_dpi;
> + /* fall through */
> case kone_mouse_event_osd_profile:
> kone->actual_profile = event->value;
> break;
I *think* the fall-through is correct thing to do here, but I'd like to
get explicit Ack from Stefan. Stefan, please?
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] HID: roccat: Mark expected switch fall-through
@ 2019-02-11 21:53 Gustavo A. R. Silva
2019-02-19 13:16 ` Jiri Kosina
0 siblings, 1 reply; 6+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-11 21:53 UTC (permalink / raw)
To: Stefan Achatz, Jiri Kosina, Benjamin Tissoires
Cc: linux-input, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/hid/hid-roccat-kone.c: In function ‘kone_keep_values_up_to_date’:
drivers/hid/hid-roccat-kone.c:784:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
kone->actual_dpi = kone->profiles[event->value - 1].
~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
startup_dpi;
~~~~~~~~~~~
drivers/hid/hid-roccat-kone.c:786:2: note: here
case kone_mouse_event_osd_profile:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/hid/hid-roccat-kone.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
index bf4675a27396..c4dd6162c1d6 100644
--- a/drivers/hid/hid-roccat-kone.c
+++ b/drivers/hid/hid-roccat-kone.c
@@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct kone_device *kone,
case kone_mouse_event_switch_profile:
kone->actual_dpi = kone->profiles[event->value - 1].
startup_dpi;
+ /* fall through */
case kone_mouse_event_osd_profile:
kone->actual_profile = event->value;
break;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: roccat: Mark expected switch fall-through
2019-02-11 21:53 [PATCH] HID: roccat: Mark expected switch fall-through Gustavo A. R. Silva
@ 2019-02-19 13:16 ` Jiri Kosina
2019-02-20 8:15 ` Stefan Achatz
0 siblings, 1 reply; 6+ messages in thread
From: Jiri Kosina @ 2019-02-19 13:16 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Stefan Achatz, Benjamin Tissoires, linux-input, linux-kernel,
Kees Cook
On Mon, 11 Feb 2019, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/hid/hid-roccat-kone.c: In function ‘kone_keep_values_up_to_date’:
> drivers/hid/hid-roccat-kone.c:784:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
> kone->actual_dpi = kone->profiles[event->value - 1].
> ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> startup_dpi;
> ~~~~~~~~~~~
> drivers/hid/hid-roccat-kone.c:786:2: note: here
> case kone_mouse_event_osd_profile:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/hid/hid-roccat-kone.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-roccat-kone.c
> index bf4675a27396..c4dd6162c1d6 100644
> --- a/drivers/hid/hid-roccat-kone.c
> +++ b/drivers/hid/hid-roccat-kone.c
> @@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct kone_device *kone,
> case kone_mouse_event_switch_profile:
> kone->actual_dpi = kone->profiles[event->value - 1].
> startup_dpi;
> + /* fall through */
> case kone_mouse_event_osd_profile:
> kone->actual_profile = event->value;
> break;
Stefan, could you please confirm that this is intended behavior?
Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: roccat: Mark expected switch fall-through
2019-02-19 13:16 ` Jiri Kosina
@ 2019-02-20 8:15 ` Stefan Achatz
2019-02-20 8:40 ` Jiri Kosina
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Achatz @ 2019-02-20 8:15 UTC (permalink / raw)
To: Jiri Kosina, Gustavo A. R. Silva
Cc: Stefan Achatz, Benjamin Tissoires, linux-input, linux-kernel,
Kees Cook
Am Dienstag, den 19.02.2019, 14:16 +0100 schrieb Jiri Kosina:
> On Mon, 11 Feb 2019, Gustavo A. R. Silva wrote:
>
> > In preparation to enabling -Wimplicit-fallthrough, mark switch
> > cases where we are expecting to fall through.
> >
> > This patch fixes the following warning:
> >
> > drivers/hid/hid-roccat-kone.c: In function
> > ‘kone_keep_values_up_to_date’:
> > drivers/hid/hid-roccat-kone.c:784:20: warning: this statement may
> > fall through [-Wimplicit-fallthrough=]
> > kone->actual_dpi = kone->profiles[event->value - 1].
> > ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > startup_dpi;
> > ~~~~~~~~~~~
> > drivers/hid/hid-roccat-kone.c:786:2: note: here
> > case kone_mouse_event_osd_profile:
> > ^~~~
> >
> > Warning level 3 was used: -Wimplicit-fallthrough=3
> >
> > This patch is part of the ongoing efforts to enable
> > -Wimplicit-fallthrough.
> >
> > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> > ---
> > drivers/hid/hid-roccat-kone.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hid/hid-roccat-kone.c b/drivers/hid/hid-
> > roccat-kone.c
> > index bf4675a27396..c4dd6162c1d6 100644
> > --- a/drivers/hid/hid-roccat-kone.c
> > +++ b/drivers/hid/hid-roccat-kone.c
> > @@ -783,6 +783,7 @@ static void kone_keep_values_up_to_date(struct
> > kone_device *kone,
> > case kone_mouse_event_switch_profile:
> > kone->actual_dpi = kone->profiles[event->value -
> > 1].
> > startup_dpi;
> > + /* fall through */
> > case kone_mouse_event_osd_profile:
> > kone->actual_profile = event->value;
> > break;
>
> Stefan, could you please confirm that this is intended behavior?
>
> Thanks,
I already confirmed this 7 months ago but as I see only in a reply to
you.
Yes, this patch is correct.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] HID: roccat: Mark expected switch fall-through
2019-02-20 8:15 ` Stefan Achatz
@ 2019-02-20 8:40 ` Jiri Kosina
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Kosina @ 2019-02-20 8:40 UTC (permalink / raw)
To: Stefan Achatz
Cc: Gustavo A. R. Silva, Stefan Achatz, Benjamin Tissoires,
linux-input, linux-kernel, Kees Cook
On Wed, 20 Feb 2019, Stefan Achatz wrote:
> I already confirmed this 7 months ago but as I see only in a reply to
> you.
I guess that fell in between cracks somewhere.
> Yes, this patch is correct.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-02-20 8:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-11 21:53 [PATCH] HID: roccat: Mark expected switch fall-through Gustavo A. R. Silva
2019-02-19 13:16 ` Jiri Kosina
2019-02-20 8:15 ` Stefan Achatz
2019-02-20 8:40 ` Jiri Kosina
-- strict thread matches above, loose matches on Subject: below --
2018-07-02 18:29 Gustavo A. R. Silva
2018-07-17 13:53 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).